fix: track typescript-go submodule commits#230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule ignore mode fromalltodirtyWhy
The update workflow intentionally patches files inside the
typescript-gosubmodule duringsetup-repo, which makes the submodule worktree dirty. Usingignore = allhides both that expected dirty state and the superproject gitlink change, so automated PRs can record the new upstream SHA in text while still leaving the checked-in submodule pointer unchanged.Using
ignore = dirtykeeps the expected patched worktree noise hidden while still allowing Git and the workflow to detect when thetypescript-gosubmodule commit itself has changed.Validation
pnpm setup-repopnpm lintpnpm checkpnpm test