fix: track typescript-go submodule updates#227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the automated TypeScript-Go update workflow so the generated PR commits the updated
typescript-gogitlink instead of only updating the PR body.Root cause
The repo config sets
submodule.typescript-go.ignore = all, so the workflow could read the updated nested checkout but Git would ignore the superproject gitlink change when building the generated commit.Changes
submodule.typescript-go.ignoretononeinside the workflow jobtypescript-goafter updating the submoduleThis keeps the committed submodule pointer aligned with the PR description and changelog.