Skip Effect diagnostics for external libraries#177
Merged
mattiamanzati merged 2 commits intoApr 29, 2026
Merged
Conversation
xesrevinu
force-pushed
the
fix-skip-effect-diagnostics-external-libraries
branch
from
78bb718 to
aa5a1c8
Compare
xesrevinu
force-pushed
the
fix-skip-effect-diagnostics-external-libraries
branch
from
ed2d32b to
92df01f
Compare
Contributor
|
Thanks for your PR! |
|
thanks @xesrevinu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174.
Effect diagnostics were still running on source files resolved from external libraries, including packages such as
@cloudflare/workers-typesthat expose.tsentrypoints. This can surface diagnostics fromnode_modulesand appears to trigger the reported TS2589 path.This uses TypeScript-Go's
Program.IsSourceFileFromExternalLibrarycheck in the Effect checker hook and skips those files before collecting Effect diagnostics.Validation:
nix shell nixpkgs#go_1_26 -c go test ./typescript-go/internal/ls/autoimport ./etscheckerhooks -count=1nix build .#tsgo --print-build-logstsgono longer reports Effect diagnostics from@cloudflare/workers-types/index.tsin the cms project