Skip to content

Convert to npm#21

Open
peachbits wants to merge 2 commits into
masterfrom
convert-to-npm
Open

Convert to npm#21
peachbits wants to merge 2 commits into
masterfrom
convert-to-npm

Conversation

@peachbits
Copy link
Copy Markdown
Contributor

@peachbits peachbits commented May 26, 2026

Note

Low Risk
Only package-manager config and Travis install/scripts change; no application or native runtime logic in this diff.

Overview
This PR finishes moving the repo from Yarn to npm for installs and CI.

.gitignore no longer ignores package-lock.json, so the npm lockfile is versioned. .npmrc is added with legacy-peer-deps=true and ignore-scripts=true (replacing .yarnrc, which is removed). .travis.yml now runs npm ci on install and npm run lint / npm run prepare instead of the frozen yarn equivalents.

Reviewed by Cursor Bugbot for commit c476006. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0bed030. Configure here.

Comment thread .travis.yml
- "12"
install:
- yarn install --frozen-lockfile
- npm ci
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis Node twelve breaks npm ci

High Severity

Travis still targets Node 12, whose bundled npm cannot install from a package-lock.json with lockfileVersion 3. The install step now uses npm ci, and the lockfile is no longer gitignored, so CI is likely to fail on the install phase.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0bed030. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Comment thread .travis.yml
- "12"
install:
- yarn install --frozen-lockfile
- npm ci
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Agentic Security Review
Severity: HIGH

Switching CI from Yarn with --ignore-scripts true to npm ci removes install-script hardening, so dependency lifecycle scripts can now execute during install.

Impact: A compromised or malicious package in the lockfile can run arbitrary commands in CI before build/test steps, which can tamper outputs or exfiltrate CI-accessible secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant