Remove flow-bin and Flow type-check leftovers#725
Merged
Conversation
Contributor
Author
peachbits
requested changes
Jun 12, 2026
peachbits
approved these changes
Jun 12, 2026
flow-bin shipped an x86_64-only binary that failed with EBADARCH on arm64 hosts during prepare. TypeScript is the type system of record, so the flow type-check was dead weight. Removed the flow-bin devDependency, the root .flowconfig, and the trailing flow step from build.types. The make-types.ts generator and shipped types.js.flow artifact are kept for downstream Flow consumers.
69ec166 to
fdc3ac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🚨🚨 ON MERGE: delete the arm64 flow-bin carve-out from
~/.cursor/skills/verify-repo.sh🚨🚨 . This PR removes flow-bin, making that sanctioned flow+EBADARCH skip (added 2026-06-12) dead code. The carve-out can be left in place safely (it becomes inert), but it should be deleted on merge since nothing will ever trigger it again.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
Removes all Flow tooling from the pre-TypeScript era. flow-bin shipped an x86_64-only binary, so on arm64 hosts without Rosetta any path that invoked
flowfailed withEBADARCH. This brokeyarn prepareinside verify-repo on an agent run on 2026-06-12. TypeScript is the type system of record here, and nothing in the Edge codebase consumes the generated Flow types: edge-react-gui importsedge-core-js/types, which resolves through the package'stypesexport condition to the.tssources, never thetypes.js.flowartifact.Changes:
flow-binfrom devDependencies and the root.flowconfig.build.typesscript and itsscripts/make-types.tsFlow generator.rollup-plugin-flow-entryand its twoflowEntrycalls inrollup.config.js.eslint-plugin-flowtypeand thestandard-kit/prettier/flowextend from.eslintrc.json.flow-typed/directory and thetypes.js.flowentry from the publishedfileslist, plus its.gitignore/.eslintignoreentries.yarn.lock(no transitive remnants).Breaking change for external consumers: this package no longer publishes
types.js.flow. Downstream projects that importedge-core-jsvia Flow lose their type definitions. This is intentional. Edge itself is TypeScript and is unaffected.Verification (arm64 host):
yarn installplus a cleanprepare(rimraf + allbuild.*) completes with no flow step and noEBADARCH.tscandeslintpass; the build emitstypes.jsandtypes.mjsand no longer emitstypes.js.flow.src/or runtime-emitted JS changes, so the value artifacts edge-react-gui consumes are byte-identical to master; only the droppedtypes.js.flowdiffers.Note
Medium Risk
Breaking publish contract for Flow consumers (
types.js.flowremoved); runtime behavior unchanged but any external Flow importer needs to migrate to TypeScript types.Overview
Removes the entire Flow toolchain from
edge-core-js:flow-bin,.flowconfig,flow-typed/,eslint-plugin-flowtype,scripts/make-types.ts, thebuild.typesnpm script, androllup-plugin-flow-entry(including itsflowEntryhooks inrollup.config.js). Ignore/publish lists no longer referencetypes.js.flow.Prepare/build is simpler—
prepareno longer runs a Flow type-generation or check step, which avoidsflow-binfailing with EBADARCH on arm64 hosts. The README now points readers atsrc/types/types.tsinstead of Flow types.Breaking for external consumers: the package no longer ships
types.js.flow. Downstream projects that typed against this package via Flow lose those definitions; Edge’s own apps use the packagetypesexport to.tssources and are unaffected. Nosrc/or runtime bundle changes are in this diff.Reviewed by Cursor Bugbot for commit fdc3ac1. Bugbot is set up for automated code reviews on this repo. Configure here.