Skip to content

Add wallet settings#722

Merged
peachbits merged 3 commits into
masterfrom
matthew/wallet-settings
Jun 18, 2026
Merged

Add wallet settings#722
peachbits merged 3 commits into
masterfrom
matthew/wallet-settings

Conversation

@peachbits

@peachbits peachbits commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Note

Medium Risk
Changes wallet creation, persistence, and engine configuration paths; impact is limited to plugins that set hasWalletSettings, but incorrect settings handling could affect engine behavior at runtime.

Overview
Introduces wallet-scoped settings for currencies that opt in via EdgeCurrencyInfo.hasWalletSettings. Settings are stored in WalletSettings.json, loaded at engine startup, exposed as walletSettings / changeWalletSettings on EdgeCurrencyWallet, and passed through to engines (including optional changeWalletSettings). createCurrencyWallet and createCurrencyWallets accept walletSettings in options and prewrite them to the wallet repo before applyKit so the pixie sees them on first load.

Memory wallets now receive walletSettings in engine options. Sync reload picks up WalletSettings.json when supported.

Also exposes EdgeCurrencyWallet.imported (walletInfo.imported === true) for key-imported wallets.

Split restore: when un-archiving split wallets, changeWalletStates is always invoked for the restore set (drops the previous no-op when nothing was archived/deleted).

Reviewed by Cursor Bugbot for commit 0434eee. Bugbot is set up for automated code reviews on this repo. Configure here.


@peachbits peachbits requested a review from swansontec April 6, 2026 17:24
Comment thread src/core/validate.ts Outdated
Comment thread src/core/account/account-api.ts
Comment thread src/core/currency/wallet/currency-wallet-pixie.ts Outdated
@j0ntz j0ntz force-pushed the matthew/wallet-settings branch from cdee339 to f87eace Compare May 21, 2026 18:43
Comment thread CHANGELOG.md
Comment thread src/index.ts Outdated
Comment thread src/index.ts Outdated
@j0ntz j0ntz force-pushed the matthew/wallet-settings branch from 5a222c6 to f87eace Compare May 22, 2026 10:30
Comment thread src/core/currency/wallet/currency-wallet-pixie.ts
Comment thread src/index.ts Outdated
@peachbits peachbits force-pushed the matthew/wallet-settings branch from 97cb1e0 to f87eace Compare May 26, 2026 03:35
Comment thread src/core/currency/wallet/currency-wallet-pixie.ts
@peachbits peachbits force-pushed the matthew/wallet-settings branch from f87eace to 0488b98 Compare June 11, 2026 16:38

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0488b98. Configure here.

Comment thread src/core/currency/wallet/currency-wallet-pixie.ts
@peachbits peachbits force-pushed the matthew/wallet-settings branch from 0488b98 to dd41597 Compare June 11, 2026 18:04
swansontec and others added 3 commits June 16, 2026 12:34
The items in the list are already known to need these changes, so there is no need to double-check.
This lets us control settings on a per-wallet basis, instead of per-chain (which is that the old userSettings property handles).

Co-authored-by: Cursor <cursoragent@cursor.com>
@peachbits peachbits force-pushed the matthew/wallet-settings branch from 8bea1e8 to 0434eee Compare June 16, 2026 19:38
@peachbits peachbits removed the request for review from swansontec June 16, 2026 22:51
@peachbits peachbits merged commit 6e65491 into master Jun 18, 2026
6 checks passed
@peachbits peachbits deleted the matthew/wallet-settings branch June 18, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants