Add wallet settings#722
Merged
Merged
Conversation
cdee339 to
f87eace
Compare
5a222c6 to
f87eace
Compare
97cb1e0 to
f87eace
Compare
f87eace to
0488b98
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0488b98. Configure here.
0488b98 to
dd41597
Compare
The items in the list are already known to need these changes, so there is no need to double-check.
This lets us control settings on a per-wallet basis, instead of per-chain (which is that the old userSettings property handles). Co-authored-by: Cursor <cursoragent@cursor.com>
8bea1e8 to
0434eee
Compare
j0ntz
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Changes wallet creation, persistence, and engine configuration paths; impact is limited to plugins that set
hasWalletSettings, but incorrect settings handling could affect engine behavior at runtime.Overview
Introduces wallet-scoped settings for currencies that opt in via
EdgeCurrencyInfo.hasWalletSettings. Settings are stored inWalletSettings.json, loaded at engine startup, exposed aswalletSettings/changeWalletSettingsonEdgeCurrencyWallet, and passed through to engines (including optionalchangeWalletSettings).createCurrencyWalletandcreateCurrencyWalletsacceptwalletSettingsin options and prewrite them to the wallet repo beforeapplyKitso the pixie sees them on first load.Memory wallets now receive
walletSettingsin engine options. Sync reload picks upWalletSettings.jsonwhen supported.Also exposes
EdgeCurrencyWallet.imported(walletInfo.imported === true) for key-imported wallets.Split restore: when un-archiving split wallets,
changeWalletStatesis always invoked for the restore set (drops the previous no-op when nothing was archived/deleted).Reviewed by Cursor Bugbot for commit 0434eee. Bugbot is set up for automated code reviews on this repo. Configure here.