Update Script.nsi#1
Open
Mozzy4Ever wants to merge 1 commit into
Open
Conversation
Changes to Script.nsi I've made over the last couple of installer revisions: Default install location set to C:\Eden\ to stop permission issues of ProgramFilesx86 Names changed to be specifically Eden Controller disabled by default (Probably easy to make it a Yes/No prompt during install process but 🤷) Ashita shortcut on Desktop has --noupdate to prevent updating Windower firewall rule added to prevent updates Uninstaller section modified to not yeet entire folder via RMDir, targets specific folders instead. (Uninstaller.exe doesn't get removed cause in use, not sure of a workaround to have it delete on done)
slassen
reviewed
Sep 3, 2023
Contributor
There was a problem hiding this comment.
Thanks for updating this. The goal of John and I open sourcing it was so that it was more generic. But we should probably have a branch that is Eden specific where these changes can live! Like the "C:\Eden" can go in eden branch. But then the changes that are generic like the controller disabled by default can be committed here or the path to avoid permission issue could be named "C:\XIGame" on the main branch to be more general.
|
I am not able to create a new query so I am posting my question here. I receive this warning when compiling the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to Script.nsi I've made over the last couple of installer revisions:
Default install location set to C:\Eden\ to stop permission issues of ProgramFilesx86
Names changed to be specifically Eden
Controller disabled by default (Probably easy to make it a Yes/No prompt during install process but 🤷)
Ashita shortcut on Desktop has --noupdate to prevent updating
Windower firewall rule added to prevent updates
Uninstaller section modified to not yeet entire folder via RMDir, targets specific folders instead. (Uninstaller.exe doesn't get removed cause in use, not sure of a workaround to have it delete on done)
Copyright license date update (though don't think this actually matters cause it's a free use from https://opensource.org/licenses/Zlib)