Skip to content

Update Script.nsi#1

Open
Mozzy4Ever wants to merge 1 commit into
EdenServer:masterfrom
Mozzy4Ever:patch-1
Open

Update Script.nsi#1
Mozzy4Ever wants to merge 1 commit into
EdenServer:masterfrom
Mozzy4Ever:patch-1

Conversation

@Mozzy4Ever

Copy link
Copy Markdown

Changes to Script.nsi I've made over the last couple of installer revisions:

Default install location set to C:\Eden\ to stop permission issues of ProgramFilesx86
Names changed to be specifically Eden
Controller disabled by default (Probably easy to make it a Yes/No prompt during install process but 🤷)
Ashita shortcut on Desktop has --noupdate to prevent updating
Windower firewall rule added to prevent updates
Uninstaller section modified to not yeet entire folder via RMDir, targets specific folders instead. (Uninstaller.exe doesn't get removed cause in use, not sure of a workaround to have it delete on done)
Copyright license date update (though don't think this actually matters cause it's a free use from https://opensource.org/licenses/Zlib)

Changes to Script.nsi I've made over the last couple of installer revisions:

Default install location set to C:\Eden\ to stop permission issues of ProgramFilesx86
Names changed to be specifically Eden
Controller disabled by default (Probably easy to make it a Yes/No prompt during install process but 🤷)
Ashita shortcut on Desktop has --noupdate to prevent updating
Windower firewall rule added to prevent updates
Uninstaller section modified to not yeet entire folder via RMDir, targets specific folders instead. (Uninstaller.exe doesn't get removed cause in use, not sure of a workaround to have it delete on done)

@slassen slassen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. The goal of John and I open sourcing it was so that it was more generic. But we should probably have a branch that is Eden specific where these changes can live! Like the "C:\Eden" can go in eden branch. But then the changes that are generic like the controller disabled by default can be committed here or the path to avoid permission issue could be named "C:\XIGame" on the main branch to be more general.

@AlexandreCA

AlexandreCA commented Apr 11, 2024

Copy link
Copy Markdown

I am not able to create a new query so I am posting my question here.

I receive this warning when compiling the client. 1 warning: 6010: install function "StrContains" not referenced - zeroing code (0-23) out. Is this normal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants