[CERT-210] - GitHub Actions: lint fixed#57
Closed
josephcampos-gap wants to merge 6 commits into
Closed
Conversation
Bruno Lint ReportFiles Scanned: 0 Triggered by workflow: lint-bruno.yml |
Bruno Lint ReportFiles Scanned: 278 Triggered by workflow: lint-bruno.yml |
96a90da to
6ff22fb
Compare
Bruno Lint ReportFiles Scanned: 278 Triggered by workflow: lint-bruno.yml |
6ff22fb to
1d24fc2
Compare
Bruno Lint ReportFiles Scanned: 302 Triggered by workflow: lint-bruno.yml |
71f58b1 to
9930839
Compare
Contributor
Author
|
I'm closing it since it's already part of PR #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the Bruno lint workflow and its associated validation files. The main focus is on making the workflow easier to test locally, updating validation files to use placeholder values for better reusability, and refining linting rules for more accurate error detection.
Documentation and Workflow Improvements:
.github/TESTING_ACTIONS_LOCALLY.mddetailing how to test GitHub Actions locally usingact, including troubleshooting, direct linter execution, and workflow success criteria..github/workflows/lint-bruno.ymlto reference files within thebrunodirectory, ensuring the workflow only runs when relevant files change.Validation File Updates (Bruno .bru files):
.bruvalidation files to replace hardcoded values in URLs and query parameters with[ENTER_*]placeholders, making them more generic and easier to configure for different environments. This affects files underStaffAssociation,StudentGrade, andStudentTranscripttest suites. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Linting Rule Refinements:
encodeUrl: trueandencodeUrl: falsein settings blocks, and improved the patch logic for missingencodeUrlsettings.