Skip to content

[DMS-1154] Make Smoke Test Happy #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradbanister merged 1 commit into from
Jun 13, 2026
Merged

[DMS-1154] Make Smoke Test Happy #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/metaed-plugin-edfi-api-schema/src/enhancer/OpenApiSpecificationEnhancerBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ export function createTrackedChangeDeletesSectionFor(entity: TopLevelEntity, end

return {
description: 'This GET operation provides access to deleted resource keys in the requested ChangeVersion range.',
operationId: `get${extensionPrefix}${pluralize(entity.metaEdName)}Deletes`,
operationId: `deletes${extensionPrefix}${pluralize(entity.metaEdName)}`,
parameters: newStaticTrackedChangeQueryParameters(),
responses: createTrackedChangeResponsesFor(trackedChangeSchemaNames.deleteItem),
Comment thread
bradbanister marked this conversation as resolved.
summary: 'Retrieves deleted resource keys for Change Queries.',
Expand All @@ -602,7 +602,7 @@ export function createTrackedChangeKeyChangesSectionFor(entity: TopLevelEntity,

return {
description: 'This GET operation provides access to changed resource keys in the requested ChangeVersion range.',
operationId: `get${extensionPrefix}${pluralize(entity.metaEdName)}KeyChanges`,
operationId: `keyChanges${extensionPrefix}${pluralize(entity.metaEdName)}`,
parameters: newStaticTrackedChangeQueryParameters(),
responses: createTrackedChangeResponsesFor(trackedChangeSchemaNames.keyChangeItem),
Comment thread
bradbanister marked this conversation as resolved.
summary: 'Retrieves changed resource keys for Change Queries.',
Expand Down
14 changes: 6 additions & 8 deletions packages/metaed-plugin-edfi-api-schema/test/enhancer/OpenApiResourceFragmentEnhancer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,15 +306,13 @@ describe('OpenApiResourceFragmentEnhancer', () => {
const student = namespace.entity.domainEntity.get('Student');
const studentApiData = student.data.edfiApiSchema;
const fragment = studentApiData.openApiFragments[OpenApiDocumentType.RESOURCES] as OpenApiFragment;
const deleteOperation: Operation = operationFrom(fragment, '/ed-fi/students/deletes', 'get');
const keyChangeOperation: Operation = operationFrom(fragment, '/ed-fi/students/keyChanges', 'get');

expectTrackedChangeOperation(
operationFrom(fragment, '/ed-fi/students/deletes', 'get'),
'EdFi_Student_TrackedChangeDelete',
);
expectTrackedChangeOperation(
operationFrom(fragment, '/ed-fi/students/keyChanges', 'get'),
'EdFi_Student_TrackedChangeKeyChange',
);
expect(deleteOperation.operationId).toBe('deletesStudents');
expect(keyChangeOperation.operationId).toBe('keyChangesStudents');
expectTrackedChangeOperation(deleteOperation, 'EdFi_Student_TrackedChangeDelete');
expectTrackedChangeOperation(keyChangeOperation, 'EdFi_Student_TrackedChangeKeyChange');
expect(fragment.paths?.['/ed-fi/students/deletes']?.['x-Ed-Fi-domains']).toEqual([]);
expect(fragment.paths?.['/ed-fi/students/keyChanges']?.['x-Ed-Fi-domains']).toEqual([]);
});
Expand Down
1,312 changes: 656 additions & 656 deletions ...lugin-edfi-api-schema/test/integration/artifact/v7_1/ds-5.0-api-schema-authoritative.json
View file
Open in desktop

Large diffs are not rendered by default.

1,360 changes: 680 additions & 680 deletions ...lugin-edfi-api-schema/test/integration/artifact/v7_2/ds-5.1-api-schema-authoritative.json
View file
Open in desktop

Large diffs are not rendered by default.

132 changes: 66 additions & 66 deletions ...-plugin-edfi-api-schema/test/integration/artifact/v7_2/tpdm-api-schema-authoritative.json
View file
Open in desktop

Large diffs are not rendered by default.

1,396 changes: 698 additions & 698 deletions ...lugin-edfi-api-schema/test/integration/artifact/v7_3/ds-5.2-api-schema-authoritative.json
View file
Open in desktop

Large diffs are not rendered by default.

1,820 changes: 910 additions & 910 deletions ...lugin-edfi-api-schema/test/integration/artifact/v7_3/ds-6.0-api-schema-authoritative.json
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions ...-api-schema/test/integration/artifact/v7_3/ds-6.0-homograph-api-schema-authoritative.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@
"/homograph/contacts/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographContactsDeletes",
"operationId": "deletes_HomographContacts",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -621,7 +621,7 @@
"/homograph/contacts/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographContactsKeyChanges",
"operationId": "keyChanges_HomographContacts",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -1233,7 +1233,7 @@
"/homograph/names/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographNamesDeletes",
"operationId": "deletes_HomographNames",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -1292,7 +1292,7 @@
"/homograph/names/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographNamesKeyChanges",
"operationId": "keyChanges_HomographNames",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -1845,7 +1845,7 @@
"/homograph/schoolYearTypes/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographSchoolYearTypesDeletes",
"operationId": "deletes_HomographSchoolYearTypes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -1904,7 +1904,7 @@
"/homograph/schoolYearTypes/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographSchoolYearTypesKeyChanges",
"operationId": "keyChanges_HomographSchoolYearTypes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -2536,7 +2536,7 @@
"/homograph/schools/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographSchoolsDeletes",
"operationId": "deletes_HomographSchools",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -2595,7 +2595,7 @@
"/homograph/schools/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographSchoolsKeyChanges",
"operationId": "keyChanges_HomographSchools",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -3350,7 +3350,7 @@
"/homograph/staffs/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStaffsDeletes",
"operationId": "deletes_HomographStaffs",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -3409,7 +3409,7 @@
"/homograph/staffs/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStaffsKeyChanges",
"operationId": "keyChanges_HomographStaffs",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4084,7 +4084,7 @@
"/homograph/studentSchoolAssociations/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStudentSchoolAssociationsDeletes",
"operationId": "deletes_HomographStudentSchoolAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4143,7 +4143,7 @@
"/homograph/studentSchoolAssociations/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStudentSchoolAssociationsKeyChanges",
"operationId": "keyChanges_HomographStudentSchoolAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4848,7 +4848,7 @@
"/homograph/students/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStudentsDeletes",
"operationId": "deletes_HomographStudents",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4907,7 +4907,7 @@
"/homograph/students/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_HomographStudentsKeyChanges",
"operationId": "keyChanges_HomographStudents",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down
28 changes: 14 additions & 14 deletions ...dfi-api-schema/test/integration/artifact/v7_3/ds-6.0-sample-api-schema-authoritative.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@
"/sample/artMediumDescriptors/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleArtMediaDeletes",
"operationId": "deletes_SampleArtMedia",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -513,7 +513,7 @@
"/sample/artMediumDescriptors/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleArtMediaKeyChanges",
"operationId": "keyChanges_SampleArtMedia",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -1942,7 +1942,7 @@
"/sample/busRoutes/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleBusRoutesDeletes",
"operationId": "deletes_SampleBusRoutes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -2001,7 +2001,7 @@
"/sample/busRoutes/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleBusRoutesKeyChanges",
"operationId": "keyChanges_SampleBusRoutes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -2638,7 +2638,7 @@
"/sample/buses/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleBusesDeletes",
"operationId": "deletes_SampleBuses",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -2697,7 +2697,7 @@
"/sample/buses/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleBusesKeyChanges",
"operationId": "keyChanges_SampleBuses",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4410,7 +4410,7 @@
"/sample/favoriteBookCategoryDescriptors/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleFavoriteBookCategoriesDeletes",
"operationId": "deletes_SampleFavoriteBookCategories",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -4469,7 +4469,7 @@
"/sample/favoriteBookCategoryDescriptors/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleFavoriteBookCategoriesKeyChanges",
"operationId": "keyChanges_SampleFavoriteBookCategories",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -5145,7 +5145,7 @@
"/sample/membershipTypeDescriptors/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleMembershipTypesDeletes",
"operationId": "deletes_SampleMembershipTypes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -5204,7 +5204,7 @@
"/sample/membershipTypeDescriptors/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleMembershipTypesKeyChanges",
"operationId": "keyChanges_SampleMembershipTypes",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -7454,7 +7454,7 @@
"/sample/studentArtProgramAssociations/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleStudentArtProgramAssociationsDeletes",
"operationId": "deletes_SampleStudentArtProgramAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -7513,7 +7513,7 @@
"/sample/studentArtProgramAssociations/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleStudentArtProgramAssociationsKeyChanges",
"operationId": "keyChanges_SampleStudentArtProgramAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -10560,7 +10560,7 @@
"/sample/studentGraduationPlanAssociations/deletes": {
"get": {
"description": "This GET operation provides access to deleted resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleStudentGraduationPlanAssociationsDeletes",
"operationId": "deletes_SampleStudentGraduationPlanAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down Expand Up @@ -10619,7 +10619,7 @@
"/sample/studentGraduationPlanAssociations/keyChanges": {
"get": {
"description": "This GET operation provides access to changed resource keys in the requested ChangeVersion range.",
"operationId": "get_SampleStudentGraduationPlanAssociationsKeyChanges",
"operationId": "keyChanges_SampleStudentGraduationPlanAssociations",
"parameters": [
{
"$ref": "#/components/parameters/MinChangeVersion"
Expand Down
Loading
Loading