Skip to content

[APIPUB-114] - Make knownUnremediatedRequests a ConcurrentDictionary #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ea-mtenhoor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[APIPUB-114] - Make knownUnremediatedRequests a ConcurrentDictionary #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...Publisher.Connections.Api/Processing/Target/Blocks/PostResourceProcessingBlocksFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public PostResourceProcessingBlocksFactory(
public (ITargetBlock<PostItemMessage>, ISourceBlock<ErrorItemMessage>) CreateProcessingBlocks(
CreateBlocksRequest createBlocksRequest)
{
var knownUnremediatedRequests = new HashSet<(string resourceUrl, HttpStatusCode statusCode)>();
var knownUnremediatedRequests = new ConcurrentDictionary<(string resourceUrl, HttpStatusCode statusCode), byte>();

var options = createBlocksRequest.Options;

Expand Down Expand Up @@ -120,7 +120,7 @@ private async Task<IEnumerable<ErrorItemMessage>> HandlePostItemMessage(
Options options,
Func<string> javaScriptModuleFactory,
EdFiApiClient targetEdFiApiClient,
HashSet<(string resourceUrl, HttpStatusCode statusCode)> knownUnremediatedRequests,
ConcurrentDictionary<(string resourceUrl, HttpStatusCode statusCode), byte> knownUnremediatedRequests,
Dictionary<string, string> missingDependencyByResourcePath)
{
if (ignoredResourceByUrl.ContainsKey(postItemMessage.ResourceUrl))
Expand Down Expand Up @@ -197,7 +197,7 @@ private async Task<IEnumerable<ErrorItemMessage>> HandlePostItemMessage(

if (!remediationResult.FoundRemediation)
{
knownUnremediatedRequests.Add((postItemMessage.ResourceUrl, result.Result.StatusCode));
knownUnremediatedRequests.TryAdd((postItemMessage.ResourceUrl, result.Result.StatusCode), 0);

return;
}
Expand Down Expand Up @@ -461,7 +461,7 @@ bool IsBadRequestForUnresolvedReferenceOfPrimaryRelationship(HttpResponseMessage

bool MayHaveRemediation(string resourceUrl, HttpStatusCode statusCode)
{
return !knownUnremediatedRequests.Contains((resourceUrl, statusCode));
return !knownUnremediatedRequests.ContainsKey((resourceUrl, statusCode));
}

async Task<string> GetResponseMessageTextAsync(HttpResponseMessage response)
Expand Down
Loading