fix(hud): keep all AirPods listening modes visible in the notch HUD - #652
fix(hud): keep all AirPods listening modes visible in the notch HUD#652mehmetefeaytas wants to merge 1 commit into
Conversation
The listening-mode label used a trailing-aligned Text only for Transparency/Off and a MarqueeText for the longer modes (Noise Cancellation / Adaptive Audio / Conversation Awareness). MarqueeText is `.leading`-aligned internally, so those labels hugged the notch edge and were clipped behind it — only Transparency/Off stayed visible. Render every mode with a single trailing-aligned, scaling Text so all listening modes remain on screen. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesListening Mode Layout
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
When the AirPods listening mode changes, only Transparency (and Off) showed in the notch HUD; Noise Cancellation, Adaptive Audio, and Conversation Awareness stayed hidden behind the notch.
Root cause
In
InlineHUD.swift, the trailing mode label used a trailing-alignedTextonly for.transparency/.off, and aMarqueeTextfor the longer modes.MarqueeTextis.leading-aligned internally, so those labels hugged the notch edge and were clipped behind it — while the trailing-alignedTextmodes stayed visible.Fix
Render every listening mode with a single trailing-aligned, scaling
Text(minimumScaleFactor(0.6),truncationMode(.tail)). All modes now stay visible; long names shrink/truncate instead of scrolling.Tested on macOS 26.5.2.
Summary by CodeRabbit