Fix/fix calender manager events

[underdog-org]

Summary

Fixes #156 — all-day events do not appear in the notch calendar until the user scrolls up, and re-hide when the day is revisited.

Root cause

Events are sorted by start time, so all-day events (whose start is midnight) always sort to the top of the list. EventListView.scrollToRelevantEvent selected the next timed event as its target and pinned it to the top of the viewport (anchor: .top). That pushed the all-day events above the visible area, so they were only reachable by scrolling up. Because the scroll runs on .onAppear and .onChange(of: filteredEvents), they re-hid every time the day was revisited.

Fix

Prefer the first all-day event as the scroll anchor when one exists, so it stays visible with upcoming timed events just below:

- guard let target = nonAllDayUpcoming ?? firstAllDay ?? lastEvent else { return }
+ guard let target = firstAllDay ?? nonAllDayUpcoming ?? lastEvent else { return }

When there are no all-day events, firstAllDay is nil and the logic falls through to the next timed event exactly as before — so days without all-day events are unaffected.

Testing

• With an all-day event and later timed events on the same day: the all-day event is now visible at the top immediately, and stays visible after closing/reopening the calendar or switching days and returning.
• Days with only timed events: unchanged (still auto-scrolls to the next upcoming event).
• Requires hideAllDayEvents to be off (otherwise all-day events are hidden by design).

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Updated the calendar event list’s initial scroll position to prioritize all-day events when both all-day and upcoming timed events are available.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 774c07c6-a418-428a-b880-c5f55e47d6af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}