Conversation
EbParsa
added
enhancement
EbParsa
added
demo
mkh-user
added
bug
mkh-user
requested changes
Jun 14, 2026
Collaborator
There was a problem hiding this comment.
- The scrolling issue still remains, we need #6 to fix it. Change title and update description.
- Captured an important bug: Masked input doesn't mask key code:
Looks great, but needs a lot of change, and I will add an issue for [masked] issue.
|
|
||
| <span class="cmt"><!-- 2. Load SDK --></span> | ||
| <span class="kw"><script</span> <span class="fn">src</span>=<span class="str">"tele.umd.min.js"</span><span class="kw">></script></span> | ||
| <!-- Live Logger & Heatmap Grid --> |
Collaborator
There was a problem hiding this comment.
This has an overflow problem on mobile like header.
| </div> | ||
|
|
||
| <div class="compare-section"> | ||
| <div class="table-container"> |
Collaborator
There was a problem hiding this comment.
This section margin for mobile is too high, so just ~2 columns of the table are visible at the same time.
| tele.<span class="fn">config</span>({ | ||
| <span class="fn">onFlush</span>: events => myApi.<span class="fn">post</span>(events) | ||
| }); | ||
| <!-- Documentation & Tabs Section --> |
Collaborator
There was a problem hiding this comment.
This section margin in too high like compare table, so other tabs are invisible and codes width is very low.
mkh-user
changed the title
mkh-user
removed
bug
mkh-user
requested changes
Jun 15, 2026
mkh-user
left a comment
mkh-user
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but needs further optimization for mobile. Overflow and collapsed table issues still remain from the previous review.
mkh-user
requested changes
Jun 15, 2026
mkh-user
left a comment
mkh-user
left a comment
Collaborator
There was a problem hiding this comment.
Changes to fix demo issues in GitHub pages
| flex-direction: column; | ||
| transition: var(--transition-smooth); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| .panel-header { | |
| padding-bottom: 20px; | |
| } |
|
|
||
| <!-- Load SDK --> | ||
| <script src="../dist/tele.umd.js" | ||
| onerror="this.onerror=null; this.src='https://cdn.jsdelivr.net/npm/telesense/dist/tele.umd.min.js';"></script> |
Collaborator
There was a problem hiding this comment.
Fallback to real demo distribution file instead of Telesense release:
Suggested change
| onerror="this.onerror=null; this.src='https://cdn.jsdelivr.net/npm/telesense/dist/tele.umd.min.js';"></script> | |
| onerror="this.onerror=null; this.src='./dist/tele.umd.js';"></script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Scroll Bug Fix & Complete UI Modernization
Summary
This PR solves the scroll stuck bug reported in the Telesense project and delivers a comprehensive UI/UX overhaul of the demo page, transforming it from a minimal, functional interface into a modern, gradient-driven, interactive experience.
Key Changes
✨ UI/UX Improvements
🎨 Visual Features
📱 Layout Enhancements
📖 Documentation Section
🔧 Technical
Testing Checklist
Files Modified
demo/index.html- Complete rewrite with new HTML structure and CSSNote: This is a visual and UX enhancement that also fixes the reported scroll bug. No SDK changes were made—only the demo page presentation layer was modernized.