fix: display profile parameters by specificity (value > constraint > label)#85
Open
Palladium-Innovations wants to merge 1 commit into
Conversation
…label) The parameter list at the top of a control in the profile view conflated labels, constraints, and values under a "Parameter Constraints" header. That header is misleading: constraints are optional, and a given row may hold a label, a constraint, or a value. Show each parameter by the most specific thing available — a value assignment, else a constraint, else the catalog label — title the section "Parameters", and tag each row with which of the three it is. Fixes EasyDynamics#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #49. In the profile control view, the parameter list was shown under a
"Parameter Constraints" header that stacked the label, constraints, and values
together. As the issue notes, that header is misleading — constraints are optional,
and a given row may actually hold a label, a constraint, or a value.
This changes the display to follow the specificity hierarchy described in the issue,
showing the most specific available for each parameter:
The section is retitled Parameters, the human label is resolved from the catalog,
and each row is tagged (Value / Constraint / Label) so it is clear which of the three
is being shown.
Notes
src/pages/ProfilePage.tsx(the profile control view). No behavior changes elsewhere.tsctype-checks clean and the existing test suite passes.