forgot to scale

[TheJeran]

closes #682

[gemini-code-assist]

Code Review

This pull request updates the calculation of 'timeRatio' in 'AxisLines.tsx' by wrapping it in 'useMemo' and including it in the dependency array for 'zLine'. The reviewer suggested improving the implementation by adding a safety check for division by zero when 'shape.x' is zero and replacing magic numbers with named constants to improve readability and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

This line has a couple of potential improvements:

1. Edge Case Handling: There's a potential for division by zero if shape.x is 0. This could result in timeRatio being Infinity or NaN, which might cause rendering errors. It's safer to handle this edge case explicitly.

2. Magic Numbers: The number 2 is used for both a scaling factor and a minimum value. This can be confusing. Using named constants would make the code more readable and maintainable.

Here is a suggestion that addresses both points:

Suggested change

	const timeRatio = useMemo(()=>Math.max(shape.z/shape.x * 2, 2),[shape]);
	const timeRatio = useMemo(() => {
	if (!shape.x) {
	return 2; // Fallback to the minimum value if shape.x is 0 or falsy
	}
	const SCALE_FACTOR = 2;
	const MIN_RATIO = 2;
	return Math.max((shape.z / shape.x) * SCALE_FACTOR, MIN_RATIO);
	}, [shape]);