Skip to content

fixes fetching variable repeated times.#677

Merged
lazarusA merged 3 commits into
mainfrom
la/fix_download
Jul 15, 2026
Merged

fixes fetching variable repeated times.#677
lazarusA merged 3 commits into
mainfrom
la/fix_download

Conversation

@lazarusA

@lazarusA lazarusA commented Jul 15, 2026

Copy link
Copy Markdown
Member

closes #676 #675

We need to clean-up idx4D. Will keep it for now but it should be removed for all getters, including netcdf ones.

@TheJeran

Copy link
Copy Markdown
Collaborator

yea, all that ish has gotten so bloated. At some point I will try to a simplification pass on a lot of components.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dimension selection and slicing logic to support 4D datasets, including appending the 4D index to the cache key and avoiding slicing off the first dimension in useDataFetcher.tsx. However, removing the 4D slicing logic causes targetDim to incorrectly resolve to the z dimension instead of y for 4D datasets, which needs to be fixed. Additionally, several instances of manual selection initialization in MetaDimSelector.tsx should be simplified using the existing defaultSelection helper, and redundant array scans can be optimized.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/hooks/useDataFetcher.tsx
Comment thread src/components/ui/MainPanel/MetaDimSelector.tsx Outdated
Comment thread src/components/ui/MainPanel/MetaDimSelector.tsx
Comment thread src/components/ui/MainPanel/MetaDimSelector.tsx
Comment thread src/components/ui/MainPanel/MetaDimSelector.tsx Outdated
@lazarusA
lazarusA merged commit f13a23d into main Jul 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't fetch variable again

2 participants