Fix ownership of shared secret variables#492
Open
lydiagarms wants to merge 2 commits into
Open
Conversation
…t also fix the owner via the require statement, the sharedPublicKey is used for new commitments
lydiagarms
changed the title
lydiagarms
force-pushed
the
lyd/sharedSecretOwnershipFix
branch
from
e9bab87 to
2b79ede
Compare
…tments where nullified on-chain
lydiagarms
force-pushed
the
lyd/sharedSecretOwnershipFix
branch
from
2b79ede to
36b304c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #472. This PR fixes a bug, where for shared secret variables that are modified in a function where there is a require statement such as require(msg.sender == admin), the ownership of the variable is assigned to the admin. This means the new commitment will be created under the admins public key and not the sharedPublicKey, which is what we want by default.
Checklist
How to test