Keep route tracking stable and distinguish customer notes#117
Merged
Conversation
Constraint: Reconnect snapshots may lag behind SSE progress already visible in the embedded app. Rejected: Replace the current progress object wholesale | stale snapshots regress the current stage and stop outcomes. Confidence: high Scope-risk: narrow Directive: Keep durable stop outcomes and the newest progress event monotonic during future snapshot merges. Tested: npm test; npm run build; npm run typecheck; npm run check:public-urls; git diff --check Not-tested: Live Shopify embedded reconnect against production traffic
Constraint: Existing read-only Shopify queries and scopes already provide both note values. Rejected: Separate visible table columns | the compact headerless note action preserves table width. Confidence: high Scope-risk: narrow Directive: Keep Order Note and Customer Note labels explicit and avoid unlabeled bullet lists. Tested: 373 app tests; React Router type generation; TypeScript; production client and SSR builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm test(373 passed)npm run typechecknpm run build