Keep Tracking completion visible without muting route context#111
Merged
Conversation
Completed stops retain their route-colored pins and gain a dedicated Tracking-only check badge, while the planned route remains a visible translucent solid reference beneath dashed GPS. Constraint: Preserve the shared Stops/Tracking map instance and server-owned completion state. Rejected: Dimming or graying completed Tracking pins | it hides route identity and made markers appear disabled. Confidence: high Scope-risk: narrow Directive: Keep planned route solid and actual GPS dashed; completion state belongs in the badge, not marker opacity. Tested: 351 Shopify app tests; targeted map behavior tests; typecheck; production build; public URL guard; changed-file ESLint; diff check. Not-tested: Authenticated Shopify Admin visual smoke before deployment.
OziinG
marked this pull request as ready for review
July 22, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Tracking previously reduced planned marker opacity to 42% and combined a softened route color with 22% line opacity, making route context look disabled or absent. Completion was also encoded by graying the entire marker instead of a distinct status affordance.
Validation
node --test tests/*.test.mjs— 351 passednpm run typechecknpm run buildnpm run check:public-urlsgit diff --check