Refine analysis schema: engine-neutral rotor averaging, single TI flag#2
Open
bjarketol wants to merge 1 commit into
Open
Refine analysis schema: engine-neutral rotor averaging, single TI flag#2bjarketol wants to merge 1 commit into
bjarketol wants to merge 1 commit into
Conversation
Follow-up corrections to the PyWake-submodel schema expansion (6d58bb4), scoped to not break the foxes windIO reader. - rotor_averaging.name: restyle to engine-neutral lowercase names and add the native overlap models gaussian_overlap (Niayifar/TurbOPark) and area_overlap (Jensen/PARK2); keep the old capitalized names as deprecated aliases. Note the gaussian_overlap/area_overlap vs Weighted-superposition incompatibility (Weighted needs a node model, e.g. grid). foxes ignores this field (uses background_averaging/wake_averaging), so this is safe. - TI reference flag: remove the redundant top-level use_effective_ti and standardize on the nested wake_expansion_coefficient.free_stream_ti, which foxes already reads; document its polarity. - use_effective_ws: fix misleading title (True = local/effective, not freestream). - turbulence_model: add c0 (foxes IEC reader reads c0/c1/c2). - ws_superposition: add Vector (foxes capability). - example: flow_example_timeseries rotor_averaging name GQGrid -> gq_grid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up corrections to the PyWake-submodel schema expansion (6d58bb4), scoped to not break the foxes windIO reader.