Conversation
talnor
self-requested a review
July 6, 2026 10:52
talnor
approved these changes
Jul 6, 2026
Contributor
|
merge and deploy when the docker image is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, read trimming (
TRIM) has been performed withfastp. However, fastp was designed for short reads, and there are now several tools specifically designed to perform this task on long reads.We have now added the latest version of
fastplongtodocker/Dockerfile_denovo_assembly-toolsand updated the workflow so that if the sequencing technology is ONT or PacBio, read trimming is performed with fastplong; otherwise, it defaults to fastp.