Nlp explanation#171
Conversation
…ose connections page
… compatible with new connections data format; formats code
Preview deployments for INA-tool ⚡️
Commit: Deployment ID: Static site name: |
|
The loaded example 2 did not give any suggestions. So I changed it to diff --git a/src/components/LoadExampleButton.tsx b/src/components/LoadExampleButton.tsx
index 48dfd19..fceded6 100644
--- a/src/components/LoadExampleButton.tsx
+++ b/src/components/LoadExampleButton.tsx
@@ -9,7 +9,7 @@ import {
DropdownMenuItem,
DropdownMenuTrigger,
} from "./ui/dropdown-menu";
-import { mockStatements } from "@/nlp/testdata/testData";
+import { statements as statements2 } from "@/nlp/testdata/testData";
const statements: Statement[] = [
{
@@ -136,7 +136,7 @@ function loadExample() {
function loadExample2() {
store.getState().setProjectName("Example 2");
- store.getState().setStatements(mockStatements);
+ store.getState().setStatements(statements2);
store.getState().setConnections([]);
store.getState().setConflicts([]);
}Now 6 connections are proposed. If correct can you implement this? |
sverhoeven
left a comment
There was a problem hiding this comment.
After correcting load example 2 as described in #171 (comment) I was able to get suggested connections.
The existing connections table renders correctly.

I like how bold and background color can overlap.
This PR could be improved by inline suggestions.
|
Thanks for the thorough list of suggestions @sverhoeven. Will work on them this week. |
…ghting to React component
…result to match updated load example dataset
|
@sverhoeven I have addressed all your comments in the latest commits above. The most interesting was the load example one where I did not even get any proposed connections for Example 1. Not sure if you also experienced this? I therefore had to slightly modify one of the statements for Example 1 to get a proposed connection to appear, and of course any resulting test case results dependent on this dataset. I also added two additional examples, one for Mitigations network and the other is the Inspections network (both given by Amineh via email). Let me know if this is ready to merge. Edit: actually, I think it's a good idea to ask for Amineh's feedback first before considering merging. I will do that now. |
sverhoeven
left a comment
There was a problem hiding this comment.
Thanks for resolving my requests for change.
For me its good to merge, but let us wait for review by the end-user.
…t to 100% by default (to pass tests for Fig B.3 actor connections)
sverhoeven
left a comment
There was a problem hiding this comment.
Looks good to me.
Only suggestion is to explain the 3 and 4 examples.
This PR adds features to the propose connections page which helps the user validate the proposed connections by the NLP algorithm.
Features