Java modernization with Claude#128
Open
dunedodo wants to merge 16 commits into
Open
Conversation
Added deleteObjectTolerateRetention retry logic in AbstractS3ClientTest to handle ECS "under retention" errors during test cleanup. Moved D@RE license probe to top of testCopyRangeAPI to prevent cleanup failures when test is skipped due to missing D@RE license. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
xiaoxin-ren
requested changes
May 6, 2026
…ents Changes: - S3JerseyClient: new constructor accepting ConnectorProvider; sets sun.net.http.allowRestrictedHeaders=true when HttpUrlConnectorProvider is used (required for V4 Host header pass-through); added response.close() in executeRequest() finally block to prevent connection reuse corruption. - S3EncryptionClient: new constructor accepting ConnectorProvider, delegating to S3JerseyClient for connector-aware client creation. - S3SignerV4: whitelist signed headers (host, content-type, content-md5, x-amz-*, x-emc-*) instead of signing all headers except authorization. HTTP connectors may modify standard headers after signing. - CodecFilter: removed premature x-amz-meta-* header addition that caused V2/V4 signature mismatch with HttpUrlConnector's lazy commit; added FilterOutputStream wrapper to strip Content-Length before commit to prevent invalid chunked+content-length header combination. - Test classes updated to use HttpUrlConnectorProvider via new constructor. - log4j2.xml: enable debug logging for S3Signer and ErrorFilter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.