Conversation
Add the dprod-shapes namespace (https://ekgf.github.io/dprod/shapes/) to the spec's normative namespaces section and remove unused sdo prefix from dprod-shapes.ttl. Resolves: DPROD-16, #29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add RDFS.label to IGNORED_NODE_SHAPE_PREDICATES so that shape labels (ending in " shape") no longer overwrite OWL class labels in the generated specification. Also remove a stale merge conflict marker in main.py. Resolves: DPROD-18, #79 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add "Retire" as a terminal lifecycle status for obsolete data products, aligning with the CDMC source document. Resolves: DPROD-17, #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply the ODRL fixes described in #83: - Change policy type from Offer to Agreement (required to have assignee) - Add assignee as PartyCollection with spatial refinement - Move spatial constraint from permission constraint to assignee refinement - Change action from odrl:read to odrl:use (read is not an ODRL term) - Update README.md inline example to match Resolves: DPROD-20, #83 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move assigner/target inside permission and add source to PartyCollection, as suggested by @joshcornejo. Co-Authored-By: Josh Cornejo <10956002+joshcornejo@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…DPROD-23, Closes #101) Co-authored-by: Cursor <cursoragent@cursor.com>
jgeluk
changed the title
Merges DPROD-17 into ballot/4. **Issue:** #28 — Include a terminal state for the Data Product **Changes:** - `ontology/dprod/dprod-ontology.ttl`: add Retire to DataProductLifecycleStatus enumeration - `ontology/dprod/dprod-shapes.ttl`: align shapes with ontology Part of ballot/4 consolidation (DPROD-16, DPROD-17, DPROD-18, DPROD-20, joshcornejo-patch-2 → ballot/4). Made with [Cursor](https://cursor.com)
Merges DPROD-16 into ballot/4. **Issue:** #29 — define dprod: prefix in namespace section **Changes:** - `ontology/dprod/dprod-shapes.ttl`: namespace/prefix for shapes - `respec/template.html`: add dprod-shapes prefix to normative namespaces table Part of ballot/4 consolidation (DPROD-16, DPROD-17, DPROD-18, DPROD-20, joshcornejo-patch-2 → ballot/4). Made with [Cursor](https://cursor.com)
Merges DPROD-18 into ballot/4. **Issue:** #79 — Use of "shape" in rdfs:label of shapes makes its way into spec **Changes:** - `spec-generator/globals.py`: ignore shape-related predicates so SHACL labels don't leak - `spec-generator/main.py`: align with globals Part of ballot/4 consolidation (DPROD-16, DPROD-17, DPROD-18, DPROD-20, joshcornejo-patch-2 → ballot/4). Made with [Cursor](https://cursor.com)
#164) Merges DPROD-20 into ballot/4. **Issues:** #81 (7.6 Data Rights), #82 (Example 1), #83 (Example 2) **Changes:** - `examples/data-rights/example.jsonld`: correct ODRL modeling - `examples/data-rights/README.md`: align docs Part of ballot/4 consolidation (DPROD-16, DPROD-17, DPROD-18, DPROD-20, joshcornejo-patch-2 → ballot/4). Made with [Cursor](https://cursor.com)
…#168) Merges **DPROD-23** into ballot/4. **OMG JIRA:** DPROD-23 **GitHub issue:** #101 — Typo in Worked Examples - Core Data Product Extensions **Change:** In `examples/core-data-product-extensions/README.md`, Example 2: correct `@type` from `ex:DataProductagreement` to `ex:DataProductAgreement`. Closes #101. Made with [Cursor](https://cursor.com)
…l (DPROD-24, #98) (#169) Merges **DPROD-24** into ballot/4. **OMG JIRA:** DPROD-24 **GitHub issue:** #98 — ontology issues (references to dcat:Protocol and dcat:SecuritySchemaType; rdfs:label on securitySchemaType) **Changes:** - `ontology/dprod/dprod-shapes.ttl`: `sh:class dcat:Protocol` → `sh:class dprod:Protocol`; `sh:class dcat:SecuritySchemaType` → `sh:class dprod:SecuritySchemaType` (fixes #141) - `ontology/dprod/dprod-ontology.ttl`: `rdf:label` → `rdfs:label` on `dprod:securitySchemaType` (fixes #139) Closes #98, #141, #139. Made with [Cursor](https://cursor.com)
jgeluk
requested review from
FroehlichMarcel,
andrea-gioia,
joshcornejo,
nvar,
rivettp and
tonyseale
as code owners
## Summary - Each class section in the generated spec now renders an `Identifier:` row, mirroring the existing property layout. - Readers can immediately see the prefixed name (e.g. `dcat:DataService`) and click through to the defining vocabulary for external classes; DPROD-local classes self-link to their in-page section. - Addresses Vladimir Alexiev's feedback in #97 that `DataService` alone is ambiguous about whether DPROD is redefining `dcat:DataService` or reusing it. Resolves: DPROD-21, Closes #97 ## Test plan - [x] `bash build.sh` / `python spec-generator/main.py` succeeds - [x] `dist/index.html` shows `Identifier: dprod:DataProduct` at `#dataproductshape` - [x] `dist/index.html` shows `Identifier: dcat:DataService` linking to `http://www.w3.org/ns/dcat#DataService` at `#dataserviceshape` - [ ] Visual review of all class sections in the rendered spec Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
## Summary - Removes the `dprod:Protocol` OWL class, resolving the modeling question in #143 (part of #98). - `dprod:protocol` now points to a URI / SKOS concept rather than an under-specified class. Resolves: DPROD-33, Closes #143 ## Test plan - [ ] `bash build.sh` succeeds - [ ] Generated spec in `dist/index.html` no longer references `dprod:Protocol` - [ ] Examples still validate against updated shapes Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ballot 4 Consolidation
This PR consolidates the Ballot 4 changes from
ballot/4intodevelop.Included PRs (merged into
ballot/4)RetiretoDataProductLifecycleStatus(Include a terminal state for the Data Product #28)dprod-shapesnamespace to normative namespaces (define dprod: prefix in namespace section #29)DataProductagreementtypo in examples (Typo in Worked Examples - Core Data Product Extensions #101)Protocol/SecuritySchemaTypemodeling andrdfs:label(ontology issues #98, Ontology: use rdfs:label on dprod:securitySchemaType property #139, Shapes: fix sh:class for protocol/securitySchemaType to dprod classes #141)Notes
joshcornejo-patch-2.Ballot Process Status
This PR should remain open until Ballot 4 voting is complete.
Do not merge into
developbefore vote approval.