-
Notifications
You must be signed in to change notification settings - Fork 15
Refactor lesson2 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergioOzzon
wants to merge
3
commits into
DwarfPorter:master
Choose a base branch
from
sergioOzzon:RefactorLesson2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...1/Task1/Converter/app/src/main/java/ru/geekbrains/converter/ConvertToMetersPerSecond.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package ru.geekbrains.converter; | ||
|
|
||
| public class ConvertToMetersPerSecond implements ConvertTo { | ||
| @Override | ||
| public float Do(float sourceValue) { | ||
| return (float) sourceValue * 1000 / 3600; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
Lesson2/HomeWork/Task1/MeteoStore.java → Lesson2/HomeWork/Task1/MeteoDB.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| class MeteoStore{ | ||
| // сохранение данных в базу | ||
| boolean save(MeteoSensor meteoSensor){ | ||
| System.out.format("Saving data from sensor [%d] at %s%n temperature - %f ; humidity - %f ; pressure - %f \n\r", meteoSensor.getId(), meteoSensor.getDateTime(), meteoSensor.getTemperature(), meteoSensor.getHumidity(), meteoSensor.getPressure()); | ||
| return true; | ||
| } | ||
| class MeteoDB implements MeteoStore{ | ||
| // сохранение данных в базу | ||
| boolean save(MeteoSensor meteoSensor){ | ||
| System.out.format("Saving data from sensor [%d] at %s%n temperature - %f ; humidity - %f ; pressure - %f \n\r", meteoSensor.getId(), meteoSensor.getDateTime(), meteoSensor.getTemperature(), meteoSensor.getHumidity(), meteoSensor.getPressure()); | ||
| return true; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| class MeteoSensorAdapter implements MeteoSensor{ | ||
|
|
||
| SensorTemperature sensor; | ||
|
|
||
| public MeteoSensorAdapter(SensorTemperature sensor){ | ||
| this.sensor = sensor; | ||
| } | ||
|
|
||
| public int getId(){ | ||
| return sensor.identifier()+500; | ||
| } | ||
| public Float getTemperature(){ | ||
| return (float) sensor.temperature(); | ||
| } | ||
| public Float getHumidity(){ | ||
| return null; | ||
| } | ||
| public Float getPressure(){ | ||
| return null; | ||
| } | ||
| public LocalDateTime getDateTime(){ | ||
| return LocalDateTime.of(sensor.year(), 1, 1, 0, 0, 0).plusDays(sensor.day()-1).plusSeconds(sensor.second()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| interface MeteoStore{ | ||
| boolean save(MeteoSensor meteoSensor); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| class DisplayReport implements SendReport{ | ||
| public void output(List<ReportItem> items){ | ||
| System.out.println("Output on display"); | ||
| for(ReportItem item : items){ | ||
| System.out.format("printer %s - %f \n\r", item.getDescription(), item.getAmount()); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| interface ISendReport{ | ||
| public void output(List<ReportItem> items); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| class Programm{ | ||
| public static void main(String[] args){ | ||
| Report report = new Report(); | ||
| Report report = new Report(new DisplayReport); | ||
| report.calculate(); | ||
| report.output(); | ||
| report.setSendReport(new PrintReport()); | ||
| report.output(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,24 @@ | ||
| import java.util.*; | ||
| class Report{ | ||
| private List<ReportItem> items; // Отчетные данные | ||
| SendOutput sendOutput; | ||
|
|
||
| Report(SendOutput sendOutput){ | ||
| this.sendOutput = sendOutput; | ||
| } | ||
|
|
||
| // расчет отчетных данных | ||
| public void calculate(){ | ||
| items = new ArrayList<ReportItem>(); | ||
| items.add(new ReportItem("First", (float)5)); | ||
| items.add(new ReportItem("Second", (float)6)); | ||
| } | ||
|
|
||
|
|
||
| public void setSendOutput(SendOutput sendOutput) { | ||
| this.sendOutput = sendOutput; | ||
| } | ||
|
|
||
| public void output(){ | ||
| PrintReport reportPrint = new PrintReport(); | ||
| reportPrint.output(items); | ||
| sendOutput.output(items); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше сделать наоборот, передать report в PrintReport. Так код будет проще.