Conversation
Updates to logic, UI, and javadocs.
added testing for rollHandStatus, bankPoints, isFarkle, wonGameStatus, tallyRoundPoints, finalTallyRoundPoints, getRoundPoints, getEstRoundPoints, iterations of scoring for 1-dice, iterations of scoring for 5-dice, and scoring relating to held dice.
…Testing Merging Controller and logic testing
finished 100% line coverage
Updated LogicTesting in order to fully comply with all Checkstyle rules and properly adhere to the guidelines of our god, Checkstyle.
Mostly tested and made changes to Model test
spamming bank button after banking points no longer gives you that many points over and over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment if anything was missed, but we have good coverage, good style, good analysis. After this we will create release 2.0 and re-compile javadoc and all of the other documentation that we need.