Skip to content

Fix app detail screen crashing on Nougat #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Iamlooker merged 7 commits into from
Mar 1, 2026
Merged

Fix app detail screen crashing on Nougat #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5eef1b9
fix: Handle missing colorError attribute on Nougat
xinkev Feb 25, 2026
97486d5
Merge branch 'main' into fix/app-details-crash-on-nougat
Iamlooker Mar 1, 2026
902a9ae
chore: Rename values-v26/themes.xml to values-v26/base_theme.xml
xinkev Mar 1, 2026
cdcda20
chore: Remove redundant color entry colorError
xinkev Mar 1, 2026
9b2f51e
style: use base theme inheritance for API 26+ colorError override
xinkev Mar 1, 2026
c6aaa1b
refactor(theme): add colorError style to night theme
xinkev Mar 1, 2026
c9171f1
style: use md_theme_l_error for light theme colorError
xinkev Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/kotlin/com/looker/droidify/ui/appDetail/AppDetailAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import androidx.core.graphics.createBitmap
import androidx.core.net.toUri
import androidx.core.text.bold
import androidx.core.text.buildSpannedString
import androidx.core.util.TypedValueCompat
import androidx.core.view.isGone
import androidx.core.view.isVisible
import androidx.recyclerview.widget.LinearLayoutManager
Expand Down Expand Up @@ -448,7 +449,7 @@ class AppDetailAdapter(private val callbacks: Callbacks) :

val actionTintNormal = button.context.getColorFromAttr(android.R.attr.colorPrimary)
val actionTintOnNormal = button.context.getColorFromAttr(MaterialR.attr.colorOnPrimary)
val actionTintCancel = button.context.getColorFromAttr(android.R.attr.colorError)
val actionTintCancel = button.context.getColorFromAttr(R.attr.colorError)
val actionTintOnCancel = button.context.getColorFromAttr(MaterialR.attr.colorOnError)
val actionTintDisabled = button.context.getColorFromAttr(MaterialR.attr.colorOutline)
val actionTintOnDisabled = button.context.getColorFromAttr(android.R.attr.colorBackground)
Expand Down
6 changes: 6 additions & 0 deletions app/src/main/res/values-night-v26/base_theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="MainTheme" parent="Base.MainTheme.Night">
<item name="colorError">?android:attr/colorError</item>
</style>
</resources>
5 changes: 4 additions & 1 deletion app/src/main/res/values-night/base_theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="MainTheme" parent="Theme.Material3.DayNight.NoActionBar">
<style name="Base.MainTheme.Night" parent="Theme.Material3.DayNight.NoActionBar">
<item name="android:colorBackground">@color/md_theme_d_background</item>
<item name="colorSurface">?android:attr/colorBackground</item>
<item name="android:colorPrimaryDark">?android:attr/colorBackground</item>
</style>
<style name="MainTheme" parent="Base.MainTheme.Night">
<item name="colorError">@color/md_theme_d_error</item>
</style>
</resources>
6 changes: 6 additions & 0 deletions app/src/main/res/values-v26/base_theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="MainTheme" parent="Base.MainTheme.Light">
<item name="colorError">?android:attr/colorError</item>
</style>
</resources>
4 changes: 4 additions & 0 deletions app/src/main/res/values/attrs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<attr name="colorError" format="color|reference"/>
</resources>
7 changes: 5 additions & 2 deletions app/src/main/res/values/base_theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="MainTheme" parent="Theme.Material3.DayNight.NoActionBar">
<item name="android:colorBackground">@color/md_theme_l_background</item>
<style name="Base.MainTheme.Light" parent="Theme.Material3.DayNight.NoActionBar">
<item name="colorSurface">?android:attr/colorBackground</item>
<item name="android:colorPrimaryDark">?android:attr/colorBackground</item>
<item name="android:colorBackground">@color/md_theme_l_background</item>
</style>
<style name="MainTheme" parent="Base.MainTheme.Light">
<item name="colorError">@color/md_theme_l_error</item>
</style>
</resources>
Loading