Fix/sender stalls jvm shutdown#207
Open
RomanDavlyatshin wants to merge 4 commits into
Open
Conversation
|
iryabov
reviewed
Jun 3, 2026
| if (!scheduledThreadPool.awaitTermination(1, TimeUnit.SECONDS)) { | ||
| logger.error("Failed to send some tests prior to shutdown") | ||
| scheduledThreadPool.shutdownNow(); | ||
| if (remainingMs > 0 && !scheduledThreadPool.awaitTermination(remainingMs, TimeUnit.MILLISECONDS)) { |
Contributor
There was a problem hiding this comment.
Why do we wait for the full remainingMs instead of a shorter timeout specific to this step?
If we block here for the entire remaining shutdown window due to a stuck task, other cleanup steps may not run in time.
| logger.error("Failed to send some tests prior to shutdown") | ||
| scheduledThreadPool.shutdownNow(); | ||
| if (remainingMs > 0 && !scheduledThreadPool.awaitTermination(remainingMs, TimeUnit.MILLISECONDS)) { | ||
| logger.warn { "Test sending scheduler did not stop within ${remainingMs}ms; leaving it for JVM exit." } |
Contributor
There was a problem hiding this comment.
Why is shutdownNow() not used here?
Without it, non-daemon threads may remain running in a worst-case scenario, potentially preventing the JVM from shutting down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.