Skip to content

lint some files - #497

Merged
leon1995 merged 14 commits into
Draegerwerk:masterfrom
leon1995:linting
Jul 23, 2026
Merged

lint some files#497
leon1995 merged 14 commits into
Draegerwerk:masterfrom
leon1995:linting

Conversation

@leon1995

Copy link
Copy Markdown
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.31579% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (0f99003) to head (6ffacd9).

Files with missing lines Patch % Lines
src/sdc11073/httpserver/httprequesthandler.py 62.50% 9 Missing ⚠️
src/sdc11073/provider/subscriptionmgr.py 41.66% 7 Missing ⚠️
src/sdc11073/httpserver/httpreader.py 58.33% 5 Missing ⚠️
src/sdc11073/xml_types/basetypes.py 85.71% 3 Missing ⚠️
...c11073/provider/porttypes/stateeventserviceimpl.py 90.90% 2 Missing ⚠️
src/sdc11073/loghelper.py 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   92.04%   92.27%   +0.22%     
==========================================
  Files         106      106              
  Lines       12110    12095      -15     
==========================================
+ Hits        11147    11161      +14     
+ Misses        963      934      -29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon1995
leon1995 requested a review from a-kleinf July 14, 2026 06:20
@a-kleinf

Copy link
Copy Markdown
Collaborator

please also clean up:

src/sdc11073/provider/porttypes/descriptioneventserviceimpl.py
src/sdc11073/provider/porttypes/stateeventserviceimpl.py
src/sdc11073/provider/porttypes/waveformserviceimpl.py

Comment thread src/sdc11073/provider/porttypes/containmenttreeserviceimpl.py Outdated
Comment thread src/sdc11073/provider/porttypes/contextserviceimpl.py
Comment thread src/sdc11073/provider/porttypes/getserviceimpl.py Outdated
Comment thread src/sdc11073/provider/porttypes/localizationservice.py Outdated
Comment thread src/sdc11073/provider/porttypes/containmenttreeserviceimpl.py
Comment thread src/sdc11073/loghelper.py Outdated
Comment thread src/sdc11073/loghelper.py Outdated
Comment thread src/sdc11073/loghelper.py Outdated
Comment thread src/sdc11073/loghelper.py Outdated
Comment thread tests/test_pathelementregistry.py Outdated
@leon1995
leon1995 requested a review from a-kleinf July 22, 2026 12:12
Comment thread src/sdc11073/xml_types/dataconverters.py Outdated
Comment thread src/sdc11073/xml_types/dataconverters.py Outdated
Comment thread src/sdc11073/provider/porttypes/containmenttreeserviceimpl.py
Comment thread src/sdc11073/provider/porttypes/localizationservice.py
@leon1995
leon1995 requested a review from a-kleinf July 23, 2026 09:48
@leon1995
leon1995 merged commit 9ae1138 into Draegerwerk:master Jul 23, 2026
30 checks passed
@leon1995
leon1995 deleted the linting branch July 23, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants