fix: Handle import error in RFIDReader - #341
Open
sevjor wants to merge 1 commit into
Open
Conversation
DouglasHalse
self-requested a review
June 14, 2026 14:44
Owner
|
Installing the pre-commit hooks locally is probably the easiest way to replicate the pre-commit nags locally |
DouglasHalse
requested changes
Jun 14, 2026
| pytest-cov | ||
| pytest-asyncio No newline at end of file | ||
| pytest-asyncio | ||
| distro |
Owner
There was a problem hiding this comment.
distro will be needed on target as well. Should work on target if you put "distro" in requirements.txt rather than requirements-dev.txt
Owner
|
#342 should fix the failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFICReader only mocks gpio for windows. Since mfrc522 is not available for non-raspberry systems, other linux distros can get import error.
Added support to check what distro a linux system is running, and mock if not raspbian.
Also handle import error as a last guard.