Skip to content

Add benchkey.com resend-email template#1367

Open
Joeymaniz95 wants to merge 2 commits into
Domain-Connect:masterfrom
Joeymaniz95:benchkey-resend-email
Open

Add benchkey.com resend-email template#1367
Joeymaniz95 wants to merge 2 commits into
Domain-Connect:masterfrom
Joeymaniz95:benchkey-resend-email

Conversation

@Joeymaniz95

@Joeymaniz95 Joeymaniz95 commented Jul 11, 2026

Copy link
Copy Markdown

Description

Adds the Domain Connect template for BenchKey (providerId benchkey.com, serviceId resend-email).

BenchKey (https://benchkey.com) is repair shop management software. Customers connect their own domains to send email from their shop's address. This template applies the DNS records that setup needs: DKIM TXT, SPF TXT, and a return path MX record. The record values are provisioned per customer through Resend and passed in as template variables. Apply URLs are RS256 signed (key published at the syncPubKeyDomain).

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

(Online Editor test links being added shortly.)

Checklist of common problems

  • syncPubKeyDomain is set (dck1.benchkey.com; TXT records published and live, key id _dck1)
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set (the sync flow passes redirect_uri)
  • no TXT record contains SPF content — see justification below
  • txtConflictMatchingMode — see note below
  • no variable as bare full record value without justification — see justification below
  • no bare variable as full host label without justification — see justification below
  • no variable is used in the host field to create a subdomain
  • %host% does not appear explicitly in any host attribute
  • essential — all three records are Always; none are user-tunable (justified below)

Justifications (per-customer provider-issued records):

This template is a per-customer applier rather than a static service template. The email provider (Resend) issues each customer their exact record names and values: the DKIM selector host (e.g. resend._domainkey), and SPF/MX on a dedicated send subdomain (e.g. send). Because these arrive from the provider per customer, the host labels and record values are template variables rather than fixed constants:

  • SPF as TXT: the provider issues the complete SPF string for a dedicated send subdomain it controls (e.g. send.<domain>). There is no pre-existing SPF at that label to merge with, so SPFM has no merge target; the TXT carries the provider-issued value as a unit.
  • Bare variable hosts/values: every variable rides inside the RS256-signed query (syncPubKeyDomain dck1.benchkey.com), so values cannot be substituted or repurposed by a third party. The application only ever passes provider-issued records through.
  • txtConflictMatchingMode: the DKIM selector label is provider-unique per customer and the SPF TXT lives on the dedicated send subdomain — no shared-label TXT is written that would need conflict matching.
  • essential Always: DKIM, SPF, and return-path MX are each required for the service to function; removing any breaks sending, so none are optional/user-tunable.

Online Editor test results

Editor test link(s):
(being added — apex test and host test)

🤖 Generated with Claude Code

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jul 11, 2026
@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

Linter OK

benchkey.com.resend-email.json

Level Code Note
info DCTL1031 all record groupId values are the same

@github-actions github-actions Bot removed the Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. label Jul 11, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete, Forged editor links

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 1/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: benchkey.com.resend-email.json: no editor test link found (expected template id 'benchkey.com.resend-email')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant