Add advancedsending cname#1359
Open
adrianaleonte wants to merge 3 commits into
Open
Conversation
Removed the warnPhishing property from the JSON configuration.
PR Description Check PassedAll required sections are filled in correctly. Details |
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1008 | sharedProviderName is in use without 'shared' compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
advancedsending.com.cname.json— a generic, signed, variable-driven CNAMEtemplate for Advanced Sending Connect, a Domain Connect Service Provider operated by
Ideal Web Construct SRL (
advancedsending.com). It points a customer's subdomain atour service — for custom domains, branded links, open/click tracking, SMS short-links and
CDNs.
It is a shared template: many SaaS customers reuse this single signed template, passing
their brand via the
providerNameparameter (sharedProviderName) and their destinationhost via the
%target%variable. The subdomain label is supplied via the standardhostparameter (
hostRequired: true), not a variable.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.json(advancedsending.com.cname.json)logoUrlis actually served by a webserver (https://connect.advancedsending.com/static/logo.svg→ HTTP 200,image/svg+xml)Checklist of common problems
syncPubKeyDomainis set —connect.advancedsending.com; the public key is published as TXT at_dcpubkeyv1.connect.advancedsending.comwarnPhishingis not set alongsidesyncPubKeyDomain— the field is present but explicitlyfalse(the template is signed); it is not the prohibitedwarnPhishing: truefallback. Happy to drop the field entirely if you'd prefer it absent.syncRedirectDomainis set —advancedsending.comtxtConflictMatchingModeis set on unique TXT records — N/A (no TXT records)pointsTo(%target%), a hostname, which is necessary for a shared custom-domain templatehostlabel — the recordhostis@(fixed)hostfield to create a subdomain — the subdomain is supplied via thehostparameter, withhostRequired: true%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove — set on the CNAMEOnline Editor test results
Editor test link(s):
Test advancedsending.com/cname example.com/link
With
hostRequired: true, the apex test is exempt (per the template note); the test above uses a subdomain —host=link,target=sms.advancedsending.com— producingCNAME link.example.com → sms.advancedsending.com.