Skip to content

Add advancedsending cname#1359

Open
adrianaleonte wants to merge 3 commits into
Domain-Connect:masterfrom
adrianaleonte:add-advancedsending-cname
Open

Add advancedsending cname#1359
adrianaleonte wants to merge 3 commits into
Domain-Connect:masterfrom
adrianaleonte:add-advancedsending-cname

Conversation

@adrianaleonte

Copy link
Copy Markdown

Description

Adds advancedsending.com.cname.json — a generic, signed, variable-driven CNAME
template for Advanced Sending Connect, a Domain Connect Service Provider operated by
Ideal Web Construct SRL (advancedsending.com). It points a customer's subdomain at
our service — for custom domains, branded links, open/click tracking, SMS short-links and
CDNs.

It is a shared template: many SaaS customers reuse this single signed template, passing
their brand via the providerName parameter (sharedProviderName) and their destination
host via the %target% variable. The subdomain label is supplied via the standard host
parameter
(hostRequired: true), not a variable.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json (advancedsending.com.cname.json)
  • resource URL provided with logoUrl is actually served by a webserver (https://connect.advancedsending.com/static/logo.svg → HTTP 200, image/svg+xml)

Checklist of common problems

  • syncPubKeyDomain is set — connect.advancedsending.com; the public key is published as TXT at _dcpubkeyv1.connect.advancedsending.com
  • warnPhishing is not set alongside syncPubKeyDomain — the field is present but explicitly false (the template is signed); it is not the prohibited warnPhishing: true fallback. Happy to drop the field entirely if you'd prefer it absent.
  • syncRedirectDomain is set — advancedsending.com
  • no TXT record contains SPF content — N/A (no TXT records in this template)
  • txtConflictMatchingMode is set on unique TXT records — N/A (no TXT records)
  • no variable is used as a bare full record value — N/A; the only variable is the CNAME pointsTo (%target%), a hostname, which is necessary for a shared custom-domain template
  • no bare variable is used as the full host label — the record host is @ (fixed)
  • no variable is used in the host field to create a subdomain — the subdomain is supplied via the host parameter, with hostRequired: true
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove — set on the CNAME

Online Editor test results

Editor test link(s):
Test advancedsending.com/cname example.com/link

With hostRequired: true, the apex test is exempt (per the template note); the test above uses a subdomain — host=link, target=sms.advancedsending.com — producing CNAME link.example.com → sms.advancedsending.com.

Removed the warnPhishing property from the JSON configuration.
@github-actions github-actions Bot added the hostRequired hostRequired is set label Jul 10, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

Copy link
Copy Markdown

Linter OK

advancedsending.com.cname.json

Level Code Note
info DCTL1008 sharedProviderName is in use without 'shared' compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant