Skip to content

fix: raise checkSuites/checkRuns page size to 100#33

Merged
gdud merged 2 commits into
masterfrom
fix/increase-check-runs-page-size
May 19, 2026
Merged

fix: raise checkSuites/checkRuns page size to 100#33
gdud merged 2 commits into
masterfrom
fix/increase-check-runs-page-size

Conversation

@gdud
Copy link
Copy Markdown
Contributor

@gdud gdud commented May 19, 2026

Summary

GFM's GraphQL query hardcodes checkRuns(first: 25) and checkSuites(first: 20) (github/types.go). Once a repo's CI check suite grows past 25 check runs, GFM silently stops seeing the later runs — including required status_check_names — and every commit evaluates as StatusSuccess=false, blocking promotion.

Real-world example

DocPlanner/noa-whisper-app run 26088940665 — promotion blocked with THERE IS NO COMMITS PASSING EVALUATION despite all 6 required build_push_* checks being successful on the develop head.

Date Total runs in CI suite Required checks visible to GFM
2026-04-23 21 6/6 → promotes
2026-05-19 33 3/6 → blocked

Of the 6 required build_push-* checks, 3 sat at positions 26, 30 and 32 inside the suite — invisible to GFM.

Change

Bump both page sizes to the GraphQL maximum of 100. Minimal, no behavior change for repos already under the old limits. Proper pagination would be the long-term fix; this unblocks current users immediately.

Test plan

  • go build ./... passes (verified locally)
  • After release, re-run the noa-whisper-app promote workflow and confirm the head of develop evaluates as IS STATUS SUCCESS: ✔
  • Confirm no regression on repos that previously worked

🤖 Generated with Claude Code

gdud and others added 2 commits May 19, 2026 12:40
The hardcoded checkRuns(first: 25) silently dropped required status
checks once a repo's CI suite grew past 25 runs, causing every commit
to evaluate as StatusSuccess=false and blocking promotion. Bump both
checkSuites and checkRuns to the GraphQL maximum of 100.
v2.0.3 relies on the deprecated GitHub Actions cache v1/v2 API, which
now returns HTML error pages and breaks the Static Checks job. v3.0.1
uses actions/cache@v4. Pinned by commit SHA for supply-chain safety.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@gdud gdud merged commit d1fb8cd into master May 19, 2026
2 checks passed
gdud added a commit that referenced this pull request May 19, 2026
Restore the pre-PR-#33 default. Combined with the previous commit,
this fully reverts PR #33's GraphQL query expansion.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gdud added a commit that referenced this pull request May 19, 2026
revert: roll checkSuites/checkRuns page sizes back to PR-#33 originals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants