Resolve PR CI template failures after default-template switch#29
Merged
Conversation
Copilot created this pull request from a session on behalf of
DocGarbanzo
June 15, 2026 07:24
View session
Copilot
AI
changed the title
fix(ci): exclude scripts/ from pytest collection
Resolve PR CI template failures after default-template switch
Jun 15, 2026
DocGarbanzo
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI started failing in
test_template.py::test_driveafterdonkey5became the default template. The test invokedcomplete.drive()with a config shape that no longer guaranteedcomplete-specific flags.Root cause
test_drivecreated the default (donkey5) template, then executeddonkeycar.templates.complete.drive().complete.drive()accessedTRAIN_LOCALIZER/TRAIN_BEHAVIORSdirectly, which are not guaranteed on non-completeconfigs.Changes
test_driveto explicitly create thecompletetemplate before callingcomplete.drive.donkeycar/templates/complete.py, replaced direct config attribute access with safe defaults viagetattr(..., False)forTRAIN_LOCALIZERandTRAIN_BEHAVIORS.Representative diff