fix(api): drop invalid R2 orderBy in managed CF checker#31
Merged
Conversation
queryR2Usage ordered r2StorageAdaptiveGroups by `sum_objectCount_DESC`, an invalid enum (objectCount/payloadSize are max-aggregated gauges, not sums). The query errored every cycle, but the try/catch fell back to a bare bucket list — so R2 detailed metrics (ops, storage GB) have silently always been empty/zero, and R2 threshold violations could never fire. Same root cause as the worker fix in #30. Drop the orderBy (all returned buckets are iterated regardless of order). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30 — same latent bug, managed side.
queryR2Usageorderedr2StorageAdaptiveGroupsbysum_objectCount_DESC, an invalid enum (objectCount/payloadSizeare max-aggregated gauges, not sums). The query errored every cycle, but thetry/catchfell back to a bare bucket list — so R2 detailed metrics (ops, storage GB) have silently always been empty, and R2 threshold violations could never fire.Fix: drop the
orderBy(all returned buckets are iterated regardless of order).tscclean; 44 CF provider tests pass.🤖 Generated with Claude Code