[FEATURE] 워터마크 재처리 스케줄러 추가#119
Closed
Jong0128 wants to merge 12 commits into
Closed
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
📝 WalkthroughWalkthrough드래프트 및 수정본 제출 후 워터마크를 비동기로 생성하고, 처리 실패 또는 장기 정체 파일을 제한된 횟수만큼 재처리하는 기능을 추가했습니다. 이미지 변환, S3 입출력, 상태 전이, 재시도 스케줄러와 관련 테스트가 포함됩니다. Changes워터마크 처리 흐름
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DesignerDraftFacade
participant DraftWatermarkListener
participant DraftWatermarkService
participant S3FileManager
participant DraftWatermarkTransitionService
DesignerDraftFacade->>DraftWatermarkListener: DraftFilesSubmittedEvent 발행
DraftWatermarkListener->>DraftWatermarkService: 커밋 이후 비동기 처리
DraftWatermarkService->>S3FileManager: 원본 다운로드 및 결과 업로드
DraftWatermarkService->>DraftWatermarkTransitionService: 완료 또는 실패 전이
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Related issue
Closes #116
#️⃣ Summary
PROCESSING) 파일을 주기적으로 재처리하는 스케줄러를 추가했습니다.🔧 Changes
WatermarkRetryScheduler— 10분 주기로 미완료 워터마크 재처리CommissionDraftFile— 재시도 카운트(watermarkRetryCount) 및 워터마크 상태 전이 메서드 추가findWatermarkRetryTargetIds+claimForRetry— 재처리 대상을 원자적으로 선점(PROCESSING 전이 + 카운트 증가)해 중복 큐잉 방지BATCH_SIZE = 20) 적용📸 Test Evidence
💬 Reviewer Notes
claimForRetry벌크 UPDATE로 대상을PROCESSING으로 선점하며updatedAt을 갱신해 다음 틱의 재선정을 차단했습니다.fail()에 도달하지 못하고 멈춘(hang) 파일도 재시도 한도(MAX_WATERMARK_RETRY = 3)에 걸려 종료되도록 했습니다.Summary by CodeRabbit
새로운 기능
개선 사항