RS-22478: fix stored XSS in metro HTML labels#51
Open
chschan wants to merge 2 commits into
Open
Conversation
Sanitise as_html label content with DOMPurify before rendering it, keeping the render-as-HTML feature while stripping scripts/handlers. Adds the dompurify dependency. Rebuilt the inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
This is perhaps risker than the other changes as it has bigger potential to break existing outputs. The standard R tests should provide some assurance. Check them before promoting the R server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitise as_html label content with DOMPurify before rendering it, keeping the render-as-HTML feature while stripping scripts/handlers. Adds the dompurify dependency.