RS-22478: Fix label xss#5
Merged
Merged
Conversation
HTML-escape the node name and column names before building the tooltip table so untrusted label data is not parsed as HTML. Rebuilt the inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The tooltip font-family comes unvalidated from config and is interpolated into an HTML style attribute, so escape it too (defense in depth). Rebuilt the copied inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JustinCCYap
reviewed
Jun 12, 2026
| var ft_f = options.tooltipsFontFamily; | ||
| var t = ""; | ||
| var nval = d.data.tips.length; | ||
| t = t + "<div class='tipTableContainer' style='white-space:nowrap;" + "font-size:" + ft_s + "px;font-family:" + ft_f + ";'>"; |
There was a problem hiding this comment.
Same comment as Displayr/rhtmlPalmTrees#63 (comment)
JustinCCYap
approved these changes
Jun 12, 2026
JustinCCYap
left a comment
JustinCCYap
left a comment
There was a problem hiding this comment.
LGTM, see comment. I think I have approved all the PRs. Let me know if I have missed one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.