-
Notifications
You must be signed in to change notification settings - Fork 0
Add AccordionExpander to Modules summary section in GenerateTab #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0d8e184
87415da
3a18224
cac80d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
|
|
||
| from core.base_tab import BaseTab | ||
| from core.project_worker import ProjectWorker | ||
| from ui.components.accordion_expander import AccordionExpander | ||
| from ui.components.validation_footer import ValidationFooter | ||
| from ui.dialogs.success_dialog import SuccessDialog | ||
|
|
||
|
|
@@ -111,7 +112,17 @@ def setup_ui(self): | |
| content_layout.addWidget(ui_group) | ||
|
|
||
| self._modules_lbl = self._make_summary_label() | ||
| modules_group = self._make_section_group("Modules", self._modules_lbl) | ||
| self._modules_expander = AccordionExpander( | ||
| "", | ||
| subtitle="Expand to review selected optional modules", | ||
| start_expanded=True, | ||
| ) | ||
| self._modules_expander.body_layout.addWidget(self._modules_lbl) | ||
| modules_group = QGroupBox("Modules") | ||
| modules_inner = QVBoxLayout() | ||
| modules_inner.setContentsMargins(6, 6, 6, 6) | ||
| modules_inner.addWidget(self._modules_expander) | ||
| modules_group.setLayout(modules_inner) | ||
|
Comment on lines
+121
to
+125
|
||
| self._section_groups["Modules"] = modules_group | ||
| content_layout.addWidget(modules_group) | ||
|
|
||
|
|
@@ -198,6 +209,7 @@ def reset(self) -> None: | |
| icon.setToolTip("") | ||
| for group in self._section_groups.values(): | ||
| group.setStyleSheet("") | ||
| self._modules_expander.set_expanded(True) | ||
| self._overall_status_lbl.setText("") | ||
| self._log_text.clear() | ||
| self._progress_bar.setValue(0) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AccordionExpanderis constructed with an empty title (""). In the currentAccordionExpanderimplementation the titleQLabelis always shown, so an empty title can still reserve vertical space and render as a blank header line. Consider providing a meaningful title (e.g. "Optional modules") or updating the component usage so the title label is hidden when the title is empty, to avoid awkward layout/UX.