Implement Save as Preset functionality

[Copilot]

save_current_as_preset was a no-op stub — it collected config but never persisted it, always emitting a misleading "Preset saved" status message.

Changes

src/ui/dialogs/save_preset_dialog.py (new)

• SavePresetDialog: prompts for a preset name (required) and optional description
• Validates on OK click; shows inline error label for empty/whitespace names
• preset_name() / description() accessors return trimmed text

src/ui/main_window.py

• Replaces the stub with the full save flow:
  1. Open SavePresetDialog; early-return on Cancel
  2. collect_configuration() → attach meta dict (name + description)
  3. ConfigManager.save_preset() → XML in ~/.plugin_configurator/presets/
  4. Status bar success message, or QMessageBox.critical on ValueError/unexpected error

src/ui/dialogs/__init__.py

• Exports SavePresetDialog

tests/test_save_preset_dialog.py (new)

• 14 tests covering init state, name validation, and accessors

# Before: stub that never saved anything
def save_current_as_preset(self):
    self.collect_configuration()
    self.status_bar.showMessage("Preset saved")

# After: full dialog → validate → serialize → persist flow
def save_current_as_preset(self):
    dialog = SavePresetDialog(parent=self)
    if dialog.exec() != QDialog.DialogCode.Accepted:
        return
    config = self.collect_configuration()
    config["meta"] = {"name": dialog.preset_name(), "description": dialog.description()}
    try:
        self._config_manager.save_preset(config, dialog.preset_name())
        self.status_bar.showMessage(f'Preset "{dialog.preset_name()}" saved successfully')
    except ValueError as exc:
        QMessageBox.critical(self, "Save Failed", f"Could not save preset:\n{exc}")

[github-actions]

📊 PR Summary

Changes Overview

• Files Changed: 0
• Python Files: 0
• Test Files: 0
• Documentation: 0
• Added: 0
• Deleted: 0

CI Checks

This PR will trigger the following checks:

Please ensure all checks pass before merging.

[github-actions]

📊 PR Summary

Changes Overview

• Files Changed: 4
• Python Files: 4
• Test Files: 1
• Documentation: 0
• Added: 2
• Deleted: 0

CI Checks

This PR will trigger the following checks:

• ✅ Linting (ruff, isort, black)
• ✅ Type Checking (mypy)
• ✅ Tests (pytest)

Please ensure all checks pass before merging.

[Copilot]

Pull request overview

Implements an actual “Save as Preset” workflow in the UI by introducing a dedicated dialog to capture preset metadata and wiring MainWindow.save_current_as_preset() to persist the collected configuration via ConfigManager.save_preset().

Changes:

• Added SavePresetDialog to collect/validate preset name + optional description.
• Replaced the previous no-op save_current_as_preset stub with dialog → collect config → persist → user feedback flow.
• Added a focused test suite for SavePresetDialog validation and accessors.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/ui/dialogs/save_preset_dialog.py	New dialog for preset name/description capture and validation.
src/ui/main_window.py	Hooks up Save-as-Preset flow to ConfigManager.save_preset() and adds error handling.
src/ui/dialogs/__init__.py	Exposes SavePresetDialog from the dialogs package.
tests/test_save_preset_dialog.py	Adds tests for dialog initialization, validation behavior, and trimmed accessors.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The preset name is later used as part of the filename (via ConfigManager.save_preset), but the dialog currently only checks for non-empty text. This allows path separators (/, \\) or traversal segments (..) and OS-invalid characters, which can lead to saving outside the presets directory or save failures on some platforms. Add validation to reject/normalize to a safe file stem (e.g., disallow separators and reserved characters) and surface a clear error message to the user.

[Copilot]

Saving a preset will overwrite an existing *.xml with the same name without any confirmation (ElementTree write() overwrites). This is inconsistent with the overwrite confirmation used in PresetManagementDialog._on_import and can cause silent data loss. Before calling save_preset, check whether the target preset file already exists and prompt the user to confirm overwrite (or offer a rename).