v0.6.0 UI6-M2: resize limits 720x720..1920x1200, spectrum absorbs vertical shortfall - #15
Open
SeamusMullan wants to merge 1 commit into
Open
v0.6.0 UI6-M2: resize limits 720x720..1920x1200, spectrum absorbs vertical shortfall#15SeamusMullan wants to merge 1 commit into
SeamusMullan wants to merge 1 commit into
Conversation
…ll in spectrum UI6-M2 partial: - New minimum 720x720 (was 760x720) so 1366x768 laptops with the host's arrange / browser strips visible can still fit the editor. - New maximum 1920x1200 (was 1600x1100) so 4K hosts can scale the editor up without absurd whitespace on the sides. - resized() now sizes the spectrum block as a flex region: it absorbs vertical shortfall down to 130 px (band bar + controlTabs keep their full size so every control stays usable). Above the default height it stays at the original 200 px — the visualiser does not benefit from extra vertical past that without a redesign. True 720x620 (the threshold target) needs DirektFlexContainer adoption across the strip layout; that is heavy churn and scoped for v0.6.1. Refs v0.6.0-threshold.md UI6-M2. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the BandGate editor’s resize constraints and updates the layout so the spectrum visualizer can shrink vertically to preserve usability of the control regions when vertical space is constrained (UI6-M2).
Changes:
- Updated editor resize limits to 720×720 .. 1920×1200.
- Modified
PluginEditor::resized()to compute a dynamic spectrum height (down to a minimum) based on remaining vertical space.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -187,11 +187,12 @@ PluginEditor::PluginEditor (PluginProcessor& p) | |||
| spectrumViz.setTooltip ("Spectral overview and per-band gating. Vertical range controls are display-only."); | |||
|
|
|||
| setSize (Layout::defaultWidth, Layout::defaultHeight); | |||
Comment on lines
+455
to
+459
| constexpr int kMinSpectrumH = 130; | ||
| const int fixedAfterSpectrum = Layout::gap + Layout::bandBarH + Layout::gap + Layout::controlsH; | ||
| const int spectrumAvail = area.getHeight() - fixedAfterSpectrum; | ||
| const int spectrumH = juce::jlimit (kMinSpectrumH, Layout::spectrumH, spectrumAvail); | ||
| spectrumViz.setBounds (area.removeFromTop (spectrumH)); |
Comment on lines
+450
to
+456
| // UI6-M2: spectrum block absorbs vertical shortfall — at the editor minimum, | ||
| // the spectrum can shrink to kMinSpectrumH while the band bar + controlTabs | ||
| // keep their full size so every control stays usable. Above default height | ||
| // it stays at the original value (visualizer does not benefit from extra | ||
| // vertical past ~200 px without redesign). | ||
| constexpr int kMinSpectrumH = 130; | ||
| const int fixedAfterSpectrum = Layout::gap + Layout::bandBarH + Layout::gap + Layout::controlsH; |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial fix for UI6-M2.
resized()now treats the spectrum block as a flex region: it absorbs vertical shortfall down to 130 px while band bar + controlTabs keep their full size so every control stays usable. Above default height it stays at the original 200 px (the visualiser doesn't benefit from extra vertical past that without a redesign).True 720 x 620 (the threshold target) requires
DirektFlexContaineradoption across the strip layout. That is heavy churn that overlaps with UI6-C4 (spectral-axis rebuild), so it is scoped for v0.6.1 follow-up.Refs
v0.6.0-threshold.mdUI6-M2.Dependencies
Test plan
cmake --build build --target BandGate_VST3succeeds.🤖 Generated with Claude Code