v0.6.0 UI6-M6 + UI6-M7: value-display polish + explicit focus order - #13
Open
SeamusMullan wants to merge 1 commit into
Open
v0.6.0 UI6-M6 + UI6-M7: value-display polish + explicit focus order#13SeamusMullan wants to merge 1 commit into
SeamusMullan wants to merge 1 commit into
Conversation
UI6-M6 — value display polish:
- Loop HPF / Loop LPF sliders now auto-promote to kHz at and above 1 kHz
(Loop LPF 12 500 Hz used to render as "12500.00 Hz", now "12.50 kHz").
- Relay feedback slider now renders its 0..1.55 ratio as a percent so the
readout matches its tooltip ("values above 100% are allowed for bloom").
UI6-M7 — explicit keyboard focus order across the editor:
- Top-row knobs 1..4 (Input / Output / Drive / Mix).
- Spectrum, GlobalControls, controlTabs at 5..7.
- GlobalControls combos numbered locally 1..4 (Bands, Min dB, Max dB, FFT).
- GateControls 1..7 (Threshold, Reduction, Smoothing, Tilt, Flip, Solo, Mute).
- RelayStrip 1..20 (Enable, Clear, time-mode combo, time, sync combo, then
the row-1 / row-2 sliders following the visual layout).
JUCE assigns focus by Z-order by default; with explicit orders, Tab now
cycles in visual reading order regardless of construction order.
Refs v0.6.0-threshold.md UI6-M6 + UI6-M7.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets UI6 threshold items by polishing slider value readouts (Hz→kHz auto-display and ratio→percent display) and by introducing explicit keyboard focus ordering across the editor and its sub-panels, so Tab traversal matches the visual layout rather than JUCE’s default Z-order.
Changes:
- Added explicit focus order indices for top-level editor controls and for controls within
GlobalControls,GateControls, andRelayStrip. - Updated
RelayStripslider readouts: Loop HPF/LPF now auto-display kHz at ≥ 1 kHz, and Relay feedback now displays as percent.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/PluginEditor.cpp | Sets explicit focus order for top-level editor components (top knobs → spectrum → global strip → tabs). |
| source/Editor/RelayStrip.cpp | Adds formatting helpers for Hz/kHz and percent readouts; assigns explicit focus order within the relay panel. |
| source/Editor/GlobalControls.cpp | Adds explicit focus order for global combo boxes. |
| source/Editor/GateControls.cpp | Adds explicit focus order for gate sliders/buttons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
57
to
+63
| setupKnob (timeSlider, timeLabel, "Delay", "ms", | ||
| "Main delay length when Delay mode is Free. Effective echo spacing also includes diffusion."); | ||
| setupKnob (feedbackSlider, feedbackLabel, "Rly FB", {}, | ||
| "Feedback around the relay path. Values above 100% are allowed for bloom; internal limiting " | ||
| "keeps the loop stable.", 54); | ||
| feedbackSlider.textFromValueFunction = formatRatioAsPercent; | ||
| feedbackSlider.updateText(); |
Comment on lines
+10
to
+15
| // UI6-M6: Hz value >= 1 kHz becomes "X.XX kHz"; under 1 kHz stays "XX Hz". | ||
| juce::String formatHzAuto (double valueHz) | ||
| { | ||
| if (valueHz >= 1000.0) | ||
| return juce::String (valueHz / 1000.0, 2) + " kHz"; | ||
| return juce::String (juce::roundToInt (valueHz)) + " Hz"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two threshold items folded together because both are coverage-pass items already mostly satisfied by the UI6-M1 decomposition.
UI6-M6 — value display polish
"12500.00 Hz"; now"12.50 kHz"."values above 100% are allowed for bloom").UI6-M7 — explicit keyboard focus order
Input / Output / Drive / Mixare 1..4.SpectrumVisualizer,GlobalControls,controlTabsare 5..7.GlobalControlscombos numbered locally 1..4 (Bands, Min dB, Max dB, FFT).GateControls1..7 (Threshold, Reduction, Smoothing, Tilt, Flip, Solo, Mute).RelayStrip1..20 — Enable, Clear, time-mode combo, time, sync combo, then row-1 / row-2 sliders following the visual layout.JUCE assigns focus by Z-order by default; with explicit orders, Tab cycles in visual reading order regardless of construction order.
Refs
v0.6.0-threshold.mdUI6-M6 + UI6-M7.Dependencies
Test plan
cmake --build build --target BandGate_VST3succeeds.kHz."… %".🤖 Generated with Claude Code