v0.6.0 UI6-C2: bump DirektDSP_GUI for accentBandGate palette - #10
Merged
Conversation
Pulls in DirektDSP/DirektDSP_GUI#57 — adds the BandGate accent and shared soloAmber/muteRed semantic entries so the UI6 work can route brand-relevant colours through DirektDSP::Colours::* instead of ad-hoc juce::Colours::* call sites. No callsite migration in this commit; that lands with UI6-C1 / UI6-M3. Refs v0.6.0-threshold.md UI6-C2. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the modules/DirektDSP_GUI git submodule pointer to pick up DirektDSP/DirektDSP_GUI#57, which introduces the new DirektDSP::Colours::accentBandGate colour and shared semantic entries (soloAmber, muteRed). This is an upstream dependency bump intended to enable a later follow-up PR to migrate BandGate’s colour routing to the shared palette.
Changes:
- Bump
modules/DirektDSP_GUIsubmodule reference to include palette extensions from DirektDSP_GUI#57. - No BandGate editor/source changes included (consumer migration deferred to a follow-up PR).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Installs DirektDSP::DirektLookAndFeel editor-wide so every child slider, combo, toggle, label, and popup picks up the BandGate accent and dark- theme palette from one place. Drops 28 off-palette `juce::Colours::*` references and ~25 redundant per-control `setColour()` calls that the LookAndFeel now owns. Remaining `setColour` sites are: - `g.setColour(...)` inside `paint()` — Graphics method, not a routing bypass; the values it pulls in come from `DirektDSP::Colours::*`. - migrationBanner + JUCE TabbedButtonBar — bespoke colour IDs that the LookAndFeel does not currently override; both are now palette-routed and marked `// THEME-EXCEPTION (UI6-M3): …` with the reason. - solo/mute/relayEnable `buttonOnColourId` — semantic palette refs (`Colours::soloAmber`, `muteRed`, `accentBandGate`), intentional per-button overrides. Refs v0.6.0-threshold.md UI6-C1 + UI6-M3. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
v0.6.0 UI6-C1 + UI6-M3: adopt DirektLookAndFeel, route colours through palette
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modules/DirektDSP_GUIsubmodule pointer to pull in feat(theme): add accentBandGate + soloAmber/muteRed palette entries DirektDSP_GUI#57, which addsDirektDSP::Colours::accentBandGateand the sharedsoloAmber/muteRedsemantic entries.Closes the first half of
v0.6.0-threshold.mdUI6-C2 (palette extension); the consumer adoption side completes when the LookAndFeel migration PR merges.Test plan
cmake --build build-rel --target BandGate_VST3succeeds.🤖 Generated with Claude Code