Refactor logic for component macros#224
Open
OCopping wants to merge 9 commits into
Open
Conversation
OCopping
force-pushed
the
refactor-logic-for-component-macros
branch
3 times, most recently
from
f8d1a0e to
016a10f
Compare
Includes new SupportEntity for structure in techui-support.yaml
…etween ioc.yaml and techui-support.yaml files This changes the logic so the macros to store from the entity in ioc.yaml are fetched from the corresponding support module entry in techui-support.yaml. This means that techui-support.yaml is the 'ground truth' of what to extract, instead of hard-coding thing inside of techui-builder like what was previously done (i.e. P, M and R). This opens up the possibilty of having other variable names in support modules. Also, the prefix structure is fetched from techui-support.yaml along with the macros, which are used to now Jinja substitute in to the prefix.
OCopping
force-pushed
the
refactor-logic-for-component-macros
branch
from
8cc25d2 to
db75bf4
Compare
Also some variable name changes
OCopping
force-pushed
the
refactor-logic-for-component-macros
branch
from
db75bf4 to
d3cea89
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 95.28% 95.14% -0.14%
==========================================
Files 10 10
Lines 890 886 -4
==========================================
- Hits 848 843 -5
- Misses 42 43 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the logic so the macros to store from the entity in
ioc.yamlare fetched from the corresponding support module entry intechui-support.yaml. This means thattechui-support.yamlis the 'ground truth' of what to extract, instead of hard-coding thing inside of techui-builder like what was previously done (i.e. P, M and R). This opens up the possibilty of having other variables names in support modules. Also, the prefix structure is fetched fromtechui-support.yamlalong with the macros, which are used to now Jinja substitute in to the prefix.