Skip to content

Mbs analyser slits#2074

Open
oliwenmandiamond wants to merge 7 commits into
mbs_detectorfrom
mbs_analyser_slits
Open

Mbs analyser slits#2074
oliwenmandiamond wants to merge 7 commits into
mbs_detectorfrom
mbs_analyser_slits

Conversation

@oliwenmandiamond
Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond commented May 28, 2026

Fixes #2069

Instructions to reviewer on how to test:

  1. Check implementation makes sense
  2. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond changed the base branch from main to mbs_detector May 28, 2026 12:48
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (153fde4) to head (ec824b3).

Additional details and impacted files
@@              Coverage Diff              @@
##           mbs_detector    #2074   +/-   ##
=============================================
  Coverage         99.14%   99.14%           
=============================================
  Files               342      343    +1     
  Lines             13281    13339   +58     
=============================================
+ Hits              13167    13225   +58     
  Misses              114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond self-assigned this May 28, 2026
@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review May 28, 2026 14:29
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner May 28, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant