Adds DCM in optics, and read-only DCM in i19_1, i19_2#2066
Merged
Conversation
…dds a factory of the actual device to _optics, makes dcm.py a standard readable with energy and wavelength
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
=======================================
Coverage 99.13% 99.14%
=======================================
Files 340 341 +1
Lines 13255 13275 +20
=======================================
+ Hits 13141 13161 +20
Misses 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noemifrisina
requested changes
May 21, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, a few things
…e/dodal into 2064_dcm_in_i19_optics
noemifrisina
requested changes
May 21, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, one more thing
…dcm_in_i19_optics
…e/dodal into 2064_dcm_in_i19_optics
noemifrisina
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2064
Adds a DCM. Not currently an optics blue api device, but does seem to connect
Makes wavelength and energy readable.