Skip to content

Update dodal to ophyd-async v0.17a5#2065

Merged
DominicOram merged 6 commits into
mainfrom
ophyd-async_v0.17a5
May 29, 2026
Merged

Update dodal to ophyd-async v0.17a5#2065
DominicOram merged 6 commits into
mainfrom
ophyd-async_v0.17a5

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

Updates dodal to latest ophyd-async release, fixing breaking changes

Instructions to reviewer on how to test:

  1. Ensure tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner May 19, 2026 16:27
@jacob720 jacob720 marked this pull request as draft May 19, 2026 16:32
@jacob720 jacob720 force-pushed the ophyd-async_v0.17a5 branch from 457da90 to ecd7baf Compare May 26, 2026 09:36
@DominicOram DominicOram marked this pull request as ready for review May 28, 2026 17:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (db3289e) to head (8795305).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2065   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         341      341           
  Lines       13287    13287           
=======================================
  Hits        13173    13173           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram
Copy link
Copy Markdown
Contributor

@oliwenmandiamond, this contains some changes to the electron analyser, which I think are just renames but you might want to double check

Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to update doc string and then good to go

Comment thread src/dodal/devices/electron_analyser/base/detector_logic.py Outdated
@DominicOram DominicOram merged commit f787f83 into main May 29, 2026
11 checks passed
@DominicOram DominicOram deleted the ophyd-async_v0.17a5 branch May 29, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants