Added e2e tests for accessibility and Create Virtual Collection flow without Keycloak mock#256
Merged
Conversation
…without Keycloak mock
ba55ie-nbc
requested changes
Jul 1, 2026
ba55ie-nbc
left a comment
ba55ie-nbc
left a comment
There was a problem hiding this comment.
Really cool that you have automated a11y tests in your project! 👍
ba55ie-nbc
approved these changes
Jul 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
What is not in this PR:
An adequate mock of the roles in Keycloak. I have not been able to mock this properly, so I found a workaround (go to the /create url directly). I need more time to figure this out.