Created a mock test suite for most of my tests and actual api tests for the navigation suite#255
Merged
Merged
Conversation
…or the navigation suite
…dency of other dependencies
|
JontySponselee-Naturalis
approved these changes
Jun 18, 2026
| # underscore is a fixed dependency of jsonpath and cannot be upgraded by us Jun-12-2026 | ||
| CVE-2026-27601 | ||
|
|
||
| # form-data is a dependency of two other packages and it cannot be automatically updated Jun-18-2026 |
Collaborator
There was a problem hiding this comment.
Sometimes it is possible to force with an explicit override, have you tried that?
Collaborator
Author
There was a problem hiding this comment.
I am still on NPM with this application because I ran into issues I don't want to fix in old code. But I know that npm also allows overrides. My larger goal is to get rid of as many dependencies I can :) A further user story tackles my dependencies and pnpm migration, and I'll take the overrides with me then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved E2E testing strategy:
For the bulk of the E2E tests I don't care what kind of response the API gives me. I am not testing my API's. I am testing my UI. So for most of my E2E tests, I am using a mocked response of the requested url. This way, when for instance the amount of Virtual Collections changes, I am not dependent on the content and my tests will not fail.
This way my tests will only fail if I break my own UI or functionality.
Whether or not my APIs give me the response I want is a different kind of test.
Note:
For the navigation E2E tests, I am actually using the actual API responses still, to keep a bit of dependency on APIs.