build(deps): align RustCrypto ECC dependency versions and remove unnecessary transitive pins#506
Merged
Benoît Cortier (CBenoit) merged 5 commits intoJun 26, 2026
Conversation
Copilot created this pull request from a session on behalf of
Benoît Cortier (CBenoit)
June 25, 2026 08:37
View session
Comment on lines
81
to
+96
| # Pin transitive dependencies versions. | ||
| # TODO: Remove when stable versions will be released. | ||
| aead = { version = "0.6", optional = true } | ||
| blake2 = { version = "=0.11.0-rc.6", optional = true } | ||
| ed25519 = "=3.0.0" | ||
| ecdsa = "=0.17.0-rc.18" | ||
| elliptic-curve = "=0.14.0-rc.33" | ||
| ecdsa = "=0.17.0-rc.22" | ||
| elliptic-curve = "0.14" | ||
| pkcs1 = "=0.8.0-rc.4" | ||
| primefield = "=0.14.0-rc.12" | ||
| primeorder = "=0.14.0-rc.10" | ||
| primefield = "0.14" | ||
| primeorder = "=0.14.0-rc.14" | ||
| ff = { version = "0.14", default-features = false } | ||
| group = "0.14" | ||
| rustcrypto-ff = "=0.14.0-rc.1" | ||
| rustcrypto-ff_derive = "=0.14.0-rc.0" | ||
| rustcrypto-group = "=0.14.0-rc.1" | ||
| curve25519-dalek = "=5.0.0-rc.0" | ||
| curve25519-dalek = "=5.0.0-rc.1" |
There was a problem hiding this comment.
Copilot Remove any dependency that we don’t need to pin anymore.
Contributor
Author
There was a problem hiding this comment.
Done in 3bd6247.
I removed the unneeded transitive RustCrypto pins from picky/Cargo.toml and refreshed both lockfiles accordingly.
elliptic-curve and align ECC stack versionselliptic-curve and align ECC stack versions
Copilot
AI
changed the title
build(deps): bump RustCrypto deps to stable
Align RustCrypto ECC dependency versions and remove unnecessary transitive pins
Jun 25, 2026
elliptic-curve and align ECC stack versions
Member
|
Copilot removed pins that are still required. I’ll do the final edits myself. |
3bd6247 to
85b51a5
Compare
Vladyslav Nikonov (vnikonov-devolutions)
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RustCrypto’s ECC stack was still on older RC-era constraints. This PR updates the direct ECC dependencies to a compatible newer set and removes transitive pins that are no longer needed, letting Cargo resolve those crates naturally (including stable
elliptic-curve).Direct dependency alignment
p256/p384/p521→=0.14.0-rc.14primeorder→=0.14.0-rc.14ecdsa→=0.17.0-rc.22ed25519-dalek/x25519-dalek→=3.0.0-rc.1curve25519-dalek→=5.0.0-rc.1Transitive pin cleanup
picky/Cargo.toml(includingelliptic-curve,primefield, and related transitive trait crates), per review feedback.Code compatibility adjustment
SignatureEncodingtrait import in Ed25519 signing code soto_vec()remains available with the resolved dependency graph.Lockfile refresh